diff options
| author | Joyee Cheung <joyeec9h3@gmail.com> | 2019-05-20 13:06:55 +0200 |
|---|---|---|
| committer | Joyee Cheung <joyeec9h3@gmail.com> | 2019-06-03 17:27:48 +0200 |
| commit | bda7da34c6f8edabf45623acb21a410c76a33bff (patch) | |
| tree | b3d4c8e40d9c316f3e620bf6f6492302b936512a /src/node_process_object.cc | |
| parent | f0018a5152a9faaf2104d62f3152776a60f59390 (diff) | |
| download | android-node-v8-bda7da34c6f8edabf45623acb21a410c76a33bff.tar.gz android-node-v8-bda7da34c6f8edabf45623acb21a410c76a33bff.tar.bz2 android-node-v8-bda7da34c6f8edabf45623acb21a410c76a33bff.zip | |
src: inline ProcessCliArgs in the Environment constructor
Inline `ProcessCliArgs()` in the `Environment` constructor, and
emit the `Environment` creation trace events with the arguments
earlier. Remove the unused arguments passed to `CreateProcessObject()`
since these are now attached to process in `PatchProcessObject()`
during pre-execution instead.
PR-URL: https://github.com/nodejs/node/pull/27539
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Diffstat (limited to 'src/node_process_object.cc')
| -rw-r--r-- | src/node_process_object.cc | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/src/node_process_object.cc b/src/node_process_object.cc index e533245703..4547025406 100644 --- a/src/node_process_object.cc +++ b/src/node_process_object.cc @@ -68,10 +68,7 @@ static void GetParentProcessId(Local<Name> property, info.GetReturnValue().Set(uv_os_getppid()); } -MaybeLocal<Object> CreateProcessObject( - Environment* env, - const std::vector<std::string>& args, - const std::vector<std::string>& exec_args) { +MaybeLocal<Object> CreateProcessObject(Environment* env) { Isolate* isolate = env->isolate(); EscapableHandleScope scope(isolate); Local<Context> context = env->context(); |