diff options
| author | Daniel Bevenius <daniel.bevenius@gmail.com> | 2018-02-20 05:21:05 +0100 |
|---|---|---|
| committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2018-02-22 06:25:47 +0100 |
| commit | 2d76379e30ea1f31593f282ab7fb5368eddd2367 (patch) | |
| tree | 8ab45a3489f4ad9efe30ab10bf396dceb0a6c4f7 /src/node_perf.cc | |
| parent | 48e90ed87e3116333f0b964a2eed352ca915a660 (diff) | |
| download | android-node-v8-2d76379e30ea1f31593f282ab7fb5368eddd2367.tar.gz android-node-v8-2d76379e30ea1f31593f282ab7fb5368eddd2367.tar.bz2 android-node-v8-2d76379e30ea1f31593f282ab7fb5368eddd2367.zip | |
src: fix deprecation warning in node_perf.cc
Currently the following deprecation warning is produced when compiling
node_perf.cc:
./src/node_perf.cc:91:11:
warning: 'MakeCallback' is deprecated: Use MakeCallback(...,
async_context) [-Wdeprecated-declarations]
node::MakeCallback(env->isolate(),
^
../src/node.h:172:50:
note: 'MakeCallback' has been explicitly marked deprecated here
NODE_EXTERN v8::Local<v8::Value> MakeCallback(
^
1 warning generated.
This commit adds an async_context to the call and checks the maybe
result.
PR-URL: https://github.com/nodejs/node/pull/18877
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Diffstat (limited to 'src/node_perf.cc')
| -rw-r--r-- | src/node_perf.cc | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/node_perf.cc b/src/node_perf.cc index 48b8d02b79..8ee805a838 100644 --- a/src/node_perf.cc +++ b/src/node_perf.cc @@ -91,7 +91,8 @@ void PerformanceEntry::Notify(Environment* env, node::MakeCallback(env->isolate(), env->process_object(), env->performance_entry_callback(), - 1, &object); + 1, &object, + node::async_context{0, 0}).ToLocalChecked(); } } |