diff options
author | Ben Noordhuis <info@bnoordhuis.nl> | 2014-11-11 00:40:58 +0100 |
---|---|---|
committer | Ben Noordhuis <info@bnoordhuis.nl> | 2014-11-11 12:02:27 +0100 |
commit | 355b96b605592d753f7381709e4827fa2e5ee29d (patch) | |
tree | c22f1a88ce8a548449baa5474396afb816cba942 /src/node_os.cc | |
parent | 454fbb803a1bef3bd53224b73fc48093c250d507 (diff) | |
download | android-node-v8-355b96b605592d753f7381709e4827fa2e5ee29d.tar.gz android-node-v8-355b96b605592d753f7381709e4827fa2e5ee29d.tar.bz2 android-node-v8-355b96b605592d753f7381709e4827fa2e5ee29d.zip |
lib,src: make os.endianness() inlinable
Turn os.endianness() from a run-time function into a pure JS function.
Upsides: makes it a good candidate for inlining at the call site.
Downsides: none that I can think of.
PR-URL: https://github.com/node-forward/node/pull/55
Reviewed-By: Chris Dickinson <christopher.s.dickinson@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Diffstat (limited to 'src/node_os.cc')
-rw-r--r-- | src/node_os.cc | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/src/node_os.cc b/src/node_os.cc index 9341ee67e6..e4d90234b9 100644 --- a/src/node_os.cc +++ b/src/node_os.cc @@ -48,6 +48,7 @@ namespace node { namespace os { using v8::Array; +using v8::Boolean; using v8::Context; using v8::FunctionCallbackInfo; using v8::Handle; @@ -59,13 +60,6 @@ using v8::String; using v8::Value; -static void GetEndianness(const FunctionCallbackInfo<Value>& args) { - Environment* env = Environment::GetCurrent(args); - const char* rval = IsBigEndian() ? "BE" : "LE"; - args.GetReturnValue().Set(OneByteString(env->isolate(), rval)); -} - - static void GetHostname(const FunctionCallbackInfo<Value>& args) { Environment* env = Environment::GetCurrent(args); char buf[MAXHOSTNAMELEN + 1]; @@ -300,7 +294,6 @@ void Initialize(Handle<Object> target, Handle<Value> unused, Handle<Context> context) { Environment* env = Environment::GetCurrent(context); - env->SetMethod(target, "getEndianness", GetEndianness); env->SetMethod(target, "getHostname", GetHostname); env->SetMethod(target, "getLoadAvg", GetLoadAvg); env->SetMethod(target, "getUptime", GetUptime); @@ -310,6 +303,8 @@ void Initialize(Handle<Object> target, env->SetMethod(target, "getOSType", GetOSType); env->SetMethod(target, "getOSRelease", GetOSRelease); env->SetMethod(target, "getInterfaceAddresses", GetInterfaceAddresses); + target->Set(FIXED_ONE_BYTE_STRING(env->isolate(), "isBigEndian"), + Boolean::New(env->isolate(), IsBigEndian())); } } // namespace os |