diff options
author | Anna Henningsen <anna@addaleax.net> | 2019-10-02 23:26:51 +0200 |
---|---|---|
committer | Rich Trott <rtrott@gmail.com> | 2019-10-05 17:48:10 -0700 |
commit | afdc3d0d187e4e3a336937df17a4c90092405e2a (patch) | |
tree | f16e7b4920a24d3ed7e711380450bd8b302ee40b /src/node_options.cc | |
parent | 28c3a9dd723e124a0e38588826c737eee7bfded5 (diff) | |
download | android-node-v8-afdc3d0d187e4e3a336937df17a4c90092405e2a.tar.gz android-node-v8-afdc3d0d187e4e3a336937df17a4c90092405e2a.tar.bz2 android-node-v8-afdc3d0d187e4e3a336937df17a4c90092405e2a.zip |
dgram: use `uv_udp_try_send()`
This improves dgram performance by avoiding unnecessary async
operations.
One issue with this commit is that it seems hard to actually create
conditions under which the fallback path to the async case is
actually taken, for all supported OS, so an internal CLI option
is used for testing that path.
Another caveat is that the lack of an async operation means
that there are slight timing differences (essentially `nextTick()`
rather than `setImmediate()` for the send callback).
PR-URL: https://github.com/nodejs/node/pull/29832
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Diffstat (limited to 'src/node_options.cc')
-rw-r--r-- | src/node_options.cc | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/node_options.cc b/src/node_options.cc index dabd03376c..ee80039e1c 100644 --- a/src/node_options.cc +++ b/src/node_options.cc @@ -453,6 +453,8 @@ EnvironmentOptionsParser::EnvironmentOptionsParser() { "write warnings to file instead of stderr", &EnvironmentOptions::redirect_warnings, kAllowedInEnvironment); + AddOption("--test-udp-no-try-send", "", // For testing only. + &EnvironmentOptions::test_udp_no_try_send); AddOption("--throw-deprecation", "throw an exception on deprecations", &EnvironmentOptions::throw_deprecation, |