diff options
| author | Anna Henningsen <anna@addaleax.net> | 2019-09-17 14:17:08 +0200 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2019-09-20 20:18:35 +0200 |
| commit | ac59dc42edb721ede2e5ddc6d1e4945ee2bf1e9c (patch) | |
| tree | b73ea409a56d4efc04dc452713d46222faed1d05 /src/node_options.cc | |
| parent | ba3be578d8bbca1bafc391984b0e6f037507dcbc (diff) | |
| download | android-node-v8-ac59dc42edb721ede2e5ddc6d1e4945ee2bf1e9c.tar.gz android-node-v8-ac59dc42edb721ede2e5ddc6d1e4945ee2bf1e9c.tar.bz2 android-node-v8-ac59dc42edb721ede2e5ddc6d1e4945ee2bf1e9c.zip | |
http: remove legacy parser
Remove the legacy `http_parser` implementation as a dependency
and all code that uses it in favor of llhttp, given that the latter
has been the default for all of Node 12 with no outstanding issues.
PR-URL: https://github.com/nodejs/node/pull/29589
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Diffstat (limited to 'src/node_options.cc')
| -rw-r--r-- | src/node_options.cc | 10 |
1 files changed, 1 insertions, 9 deletions
diff --git a/src/node_options.cc b/src/node_options.cc index 286218fb19..8a88902513 100644 --- a/src/node_options.cc +++ b/src/node_options.cc @@ -154,10 +154,6 @@ void EnvironmentOptions::CheckOptions(std::vector<std::string>* errors) { errors->push_back("either --check or --eval can be used, not both"); } - if (http_parser != "legacy" && http_parser != "llhttp") { - errors->push_back("invalid value for --http-parser"); - } - if (!unhandled_rejections.empty() && unhandled_rejections != "strict" && unhandled_rejections != "warn" && @@ -362,11 +358,7 @@ EnvironmentOptionsParser::EnvironmentOptionsParser() { "Generate heap snapshot on specified signal", &EnvironmentOptions::heap_snapshot_signal, kAllowedInEnvironment); - AddOption("--http-parser", - "Select which HTTP parser to use; either 'legacy' or 'llhttp' " - "(default: llhttp).", - &EnvironmentOptions::http_parser, - kAllowedInEnvironment); + AddOption("--http-parser", "", NoOp{}, kAllowedInEnvironment); AddOption("--input-type", "set module type for string input", &EnvironmentOptions::module_type, |