diff options
author | cjihrig <cjihrig@gmail.com> | 2019-02-18 14:01:12 -0500 |
---|---|---|
committer | cjihrig <cjihrig@gmail.com> | 2019-02-20 15:15:57 -0500 |
commit | 823c988b482e609978869820758b7182f32e9de5 (patch) | |
tree | 40f0445410b16afeec0e2e273e4890bb82e5e90e /src/node_options.cc | |
parent | 11a8a940d7bf03dc108082bdd456668210b949c1 (diff) | |
download | android-node-v8-823c988b482e609978869820758b7182f32e9de5.tar.gz android-node-v8-823c988b482e609978869820758b7182f32e9de5.tar.bz2 android-node-v8-823c988b482e609978869820758b7182f32e9de5.zip |
report: remove verbose setting
This commit removes the --diagnostic-report-verbose CLI option
and all associated logic. The flag is currently only used in one
place, and only reflects the settings at startup. Additionally,
Node tends to use the NODE_DEBUG mechanism for adding verbose
output.
PR-URL: https://github.com/nodejs/node/pull/26195
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'src/node_options.cc')
-rw-r--r-- | src/node_options.cc | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/src/node_options.cc b/src/node_options.cc index e68487a2bf..937298e0d8 100644 --- a/src/node_options.cc +++ b/src/node_options.cc @@ -90,11 +90,6 @@ void PerIsolateOptions::CheckOptions(std::vector<std::string>* errors) { "--diagnostic-report-uncaught-exception option is valid only when " "--experimental-report is set"); } - - if (report_verbose) { - errors->push_back("--diagnostic-report-verbose option is valid only when " - "--experimental-report is set"); - } #endif // NODE_REPORT } @@ -357,11 +352,6 @@ PerIsolateOptionsParser::PerIsolateOptionsParser() { " (default: current working directory of Node.js process)", &PerIsolateOptions::report_directory, kAllowedInEnvironment); - AddOption("--diagnostic-report-verbose", - "verbose option for report generation(true|false)." - " (default: false)", - &PerIsolateOptions::report_verbose, - kAllowedInEnvironment); #endif // NODE_REPORT Insert(&EnvironmentOptionsParser::instance, |