diff options
| author | Shelley Vohr <shelley.vohr@gmail.com> | 2019-10-21 08:46:34 -0700 |
|---|---|---|
| committer | Shelley Vohr <shelley.vohr@gmail.com> | 2019-10-25 08:46:00 -0700 |
| commit | 11275dcf97aaf8f89127f8cf0fc4f6fcc5e70e93 (patch) | |
| tree | 65cafc250b14df6ff541bad239acd19d9e2d11d4 /src/node_options.cc | |
| parent | bb7b48a86754a3e3facab214821ac59a0dc8c7c3 (diff) | |
| download | android-node-v8-11275dcf97aaf8f89127f8cf0fc4f6fcc5e70e93.tar.gz android-node-v8-11275dcf97aaf8f89127f8cf0fc4f6fcc5e70e93.tar.bz2 android-node-v8-11275dcf97aaf8f89127f8cf0fc4f6fcc5e70e93.zip | |
src: allow inspector without v8 platform
Embedders sometimes want to take control of V8 platform initialization
themselves, so we wouldn't want to experience an error if
NODE_USE_V8_PLATFORM was false necessarily. Instead, we can also gate
it with HAVE_INSPECTOR to allow embedders to define that themselves
and use Inspector without NODE_USE_V8_PLATFORM.
PR-URL: https://github.com/nodejs/node/pull/30049
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Diffstat (limited to 'src/node_options.cc')
| -rw-r--r-- | src/node_options.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/node_options.cc b/src/node_options.cc index ac44a758dc..8ec469d3ac 100644 --- a/src/node_options.cc +++ b/src/node_options.cc @@ -27,10 +27,10 @@ std::shared_ptr<PerProcessOptions> cli_options{new PerProcessOptions()}; } // namespace per_process void DebugOptions::CheckOptions(std::vector<std::string>* errors) { -#if !NODE_USE_V8_PLATFORM +#if !NODE_USE_V8_PLATFORM && !HAVE_INSPECTOR if (inspector_enabled) { errors->push_back("Inspector is not available when Node is compiled " - "--without-v8-platform"); + "--without-v8-platform and --without-inspector."); } #endif |