summaryrefslogtreecommitdiff
path: root/src/node_metadata.h
diff options
context:
space:
mode:
authorAnna Henningsen <anna@addaleax.net>2018-11-30 07:39:02 +0100
committerDaniel Bevenius <daniel.bevenius@gmail.com>2018-12-06 05:21:36 +0100
commitaa943d098e0299ea87485a607353d152f5ea5012 (patch)
treeb3f2cd52efc4568d5f7deb6ca99684e2f5d22a62 /src/node_metadata.h
parent7bcbf044ddc864be9d6c711a75f3a33b6a3c652e (diff)
downloadandroid-node-v8-aa943d098e0299ea87485a607353d152f5ea5012.tar.gz
android-node-v8-aa943d098e0299ea87485a607353d152f5ea5012.tar.bz2
android-node-v8-aa943d098e0299ea87485a607353d152f5ea5012.zip
http: make parser choice a runtime flag
Add a `--http-parser=llhttp` vs `--http-parser=traditional` command line switch, to make testing and comparing the new llhttp-based implementation easier. PR-URL: https://github.com/nodejs/node/pull/24739 Refs: https://github.com/nodejs/node/issues/24730 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Matheus Marchini <mat@mmarchini.me> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Diffstat (limited to 'src/node_metadata.h')
-rw-r--r--src/node_metadata.h11
1 files changed, 3 insertions, 8 deletions
diff --git a/src/node_metadata.h b/src/node_metadata.h
index 0f32fcf21d..9f383be5f8 100644
--- a/src/node_metadata.h
+++ b/src/node_metadata.h
@@ -15,13 +15,9 @@ namespace node {
V(ares) \
V(modules) \
V(nghttp2) \
- V(napi)
-
-#ifdef NODE_EXPERIMENTAL_HTTP
-#define NODE_VERSIONS_KEY_HTTP(V) V(llhttp)
-#else /* !NODE_EXPERIMENTAL_HTTP */
-#define NODE_VERSIONS_KEY_HTTP(V) V(http_parser)
-#endif /* NODE_EXPERIMENTAL_HTTP */
+ V(napi) \
+ V(llhttp) \
+ V(http_parser) \
#if HAVE_OPENSSL
#define NODE_VERSIONS_KEY_CRYPTO(V) V(openssl)
@@ -31,7 +27,6 @@ namespace node {
#define NODE_VERSIONS_KEYS(V) \
NODE_VERSIONS_KEYS_BASE(V) \
- NODE_VERSIONS_KEY_HTTP(V) \
NODE_VERSIONS_KEY_CRYPTO(V)
class Metadata {