diff options
| author | Anna Henningsen <anna@addaleax.net> | 2018-09-23 19:24:33 +0200 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2018-10-03 13:43:42 -0700 |
| commit | d527dde3600655eae7ce0ba5da9263ec4560cd11 (patch) | |
| tree | cb9186b8b85a696ec7f916f40fcec935ba86fdc9 /src/node_messaging.cc | |
| parent | 2ebdba12297348649620e3d302b156c149d85a6e (diff) | |
| download | android-node-v8-d527dde3600655eae7ce0ba5da9263ec4560cd11.tar.gz android-node-v8-d527dde3600655eae7ce0ba5da9263ec4560cd11.tar.bz2 android-node-v8-d527dde3600655eae7ce0ba5da9263ec4560cd11.zip | |
src: use JS inheritance for `AsyncWrap`
For all classes descending from `AsyncWrap`, use JS inheritance
instead of manually adding methods to the individual classes.
This allows cleanup of some code around transferring handles
over IPC.
PR-URL: https://github.com/nodejs/node/pull/23094
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src/node_messaging.cc')
| -rw-r--r-- | src/node_messaging.cc | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/src/node_messaging.cc b/src/node_messaging.cc index 6dd66f243e..0a79d6f9d3 100644 --- a/src/node_messaging.cc +++ b/src/node_messaging.cc @@ -722,9 +722,7 @@ MaybeLocal<Function> GetMessagePortConstructor( Local<FunctionTemplate> m = env->NewFunctionTemplate(MessagePort::New); m->SetClassName(env->message_port_constructor_string()); m->InstanceTemplate()->SetInternalFieldCount(1); - - AsyncWrap::AddWrapMethods(env, m); - HandleWrap::AddWrapMethods(env, m); + m->Inherit(HandleWrap::GetConstructorTemplate(env)); env->SetProtoMethod(m, "postMessage", MessagePort::PostMessage); env->SetProtoMethod(m, "start", MessagePort::Start); |