summaryrefslogtreecommitdiff
path: root/src/node_messaging.cc
diff options
context:
space:
mode:
authorAnna Henningsen <anna@addaleax.net>2019-03-07 10:18:03 +0100
committerAnna Henningsen <anna@addaleax.net>2019-03-11 09:56:56 +0000
commita52aedeae08b57daedae56fd818be09df5f32e86 (patch)
tree60b9ea606dec5bb1fdeb64eb20fd4641bf560d74 /src/node_messaging.cc
parent6113ba96cb941775f20369924484046cd8e05089 (diff)
downloadandroid-node-v8-a52aedeae08b57daedae56fd818be09df5f32e86.tar.gz
android-node-v8-a52aedeae08b57daedae56fd818be09df5f32e86.tar.bz2
android-node-v8-a52aedeae08b57daedae56fd818be09df5f32e86.zip
worker: remove `ERR_CLOSED_MESSAGE_PORT`
This aligns `MessagePort`s more with the web API. Refs: https://github.com/nodejs/node/issues/26463 PR-URL: https://github.com/nodejs/node/pull/26487 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'src/node_messaging.cc')
-rw-r--r--src/node_messaging.cc2
1 files changed, 0 insertions, 2 deletions
diff --git a/src/node_messaging.cc b/src/node_messaging.cc
index 345c496ecf..21e0191c12 100644
--- a/src/node_messaging.cc
+++ b/src/node_messaging.cc
@@ -729,7 +729,6 @@ void MessagePort::Start(const FunctionCallbackInfo<Value>& args) {
MessagePort* port;
ASSIGN_OR_RETURN_UNWRAP(&port, args.This());
if (!port->data_) {
- THROW_ERR_CLOSED_MESSAGE_PORT(env);
return;
}
port->Start();
@@ -741,7 +740,6 @@ void MessagePort::Stop(const FunctionCallbackInfo<Value>& args) {
CHECK(args[0]->IsObject());
ASSIGN_OR_RETURN_UNWRAP(&port, args[0].As<Object>());
if (!port->data_) {
- THROW_ERR_CLOSED_MESSAGE_PORT(env);
return;
}
port->Stop();