summaryrefslogtreecommitdiff
path: root/src/node_internals.h
diff options
context:
space:
mode:
authorJoyee Cheung <joyeec9h3@gmail.com>2018-11-14 22:38:12 +0800
committerJoyee Cheung <joyeec9h3@gmail.com>2018-11-20 01:17:15 +0800
commit7778c035a0a3f9bbb988eb0298a026d80f423e03 (patch)
treed3c80bffa25e84ae9993aaf0314192c2ac4f969f /src/node_internals.h
parent092ab7a1d39d97a3e93f8ed46d80d8ad783b2f9c (diff)
downloadandroid-node-v8-7778c035a0a3f9bbb988eb0298a026d80f423e03.tar.gz
android-node-v8-7778c035a0a3f9bbb988eb0298a026d80f423e03.tar.bz2
android-node-v8-7778c035a0a3f9bbb988eb0298a026d80f423e03.zip
src: use STL containers instead of v8 values for static module data
Instead of putting the source code and the cache in v8::Objects, put them in per-process std::maps. This has the following benefits: - It's slightly lighter in weight compared to storing things on the v8 heap. Also it may be slightly faster since the preivous v8::Object is already in dictionary mode - though the difference is very small given the number of native modules is limited. - The source and code cache generation templates are now much simpler since they just initialize static arrays and manipulate STL constructs. - The static native module data can be accessed independently of any Environment or Isolate, and it's easy to look them up from the C++'s side. - It's now impossible to mutate the source code used to compile native modules from the JS land since it's completely separate from the v8 heap. We can still get the constant strings from process.binding('natives') but that's all. A few drive-by fixes: - Remove DecorateErrorStack in LookupAndCompile - We don't need to capture the exception to decorate when we encounter errors during native module compilation, as those errors should be syntax errors and v8 is able to decorate them well. We use CompileFunctionInContext so there is no need to worry about wrappers either. - The code cache could be rejected when node is started with v8 flags. Instead of aborting in that case, simply keep a record in the native_module_without_cache set. - Refactor js2c.py a bit, reduce code duplication and inline Render() to make the one-byte/two-byte special treatment easier to read. PR-URL: https://github.com/nodejs/node/pull/24384 Fixes: https://github.com/Remove Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src/node_internals.h')
-rw-r--r--src/node_internals.h5
1 files changed, 5 insertions, 0 deletions
diff --git a/src/node_internals.h b/src/node_internals.h
index b6cd628086..68c0b1f753 100644
--- a/src/node_internals.h
+++ b/src/node_internals.h
@@ -171,6 +171,10 @@ struct sockaddr;
namespace node {
+namespace native_module {
+class NativeModuleLoader;
+}
+
extern Mutex process_mutex;
extern Mutex environ_mutex;
@@ -179,6 +183,7 @@ extern bool v8_initialized;
extern Mutex per_process_opts_mutex;
extern std::shared_ptr<PerProcessOptions> per_process_opts;
+extern native_module::NativeModuleLoader per_process_loader;
// Forward declaration
class Environment;