summaryrefslogtreecommitdiff
path: root/src/node_internals.h
diff options
context:
space:
mode:
authorAnna Henningsen <anna@addaleax.net>2018-09-12 15:01:50 +0200
committerAnna Henningsen <anna@addaleax.net>2018-09-17 17:20:27 +0200
commit4286dcf17f062034117043a2640b620210b61f57 (patch)
treede227e8bb7bee72778a2e7bd98f08991839bf866 /src/node_internals.h
parentc33e27dc3caf5a5b7954706fe6ecde1e4f82534d (diff)
downloadandroid-node-v8-4286dcf17f062034117043a2640b620210b61f57.tar.gz
android-node-v8-4286dcf17f062034117043a2640b620210b61f57.tar.bz2
android-node-v8-4286dcf17f062034117043a2640b620210b61f57.zip
src: refactor `Environment::GetCurrent()` usage
Make `Environment::GetCurrent()` return `nullptr` if the current `Context` is not a Node.js context, and for the relevant usage of this function, either: - Switch to the better `GetCurrent(args)` variant - Turn functions in to no-ops where it makes sense - Make it a `CHECK`, i.e. an API requirement, where it make sense - Leave a `TODO` comment for verifying what, if anything, is to be done PR-URL: https://github.com/nodejs/node/pull/22819 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Diffstat (limited to 'src/node_internals.h')
-rw-r--r--src/node_internals.h4
1 files changed, 3 insertions, 1 deletions
diff --git a/src/node_internals.h b/src/node_internals.h
index c7a4299c89..0bf08210a6 100644
--- a/src/node_internals.h
+++ b/src/node_internals.h
@@ -501,7 +501,9 @@ class InternalCallbackScope {
class ThreadPoolWork {
public:
- explicit inline ThreadPoolWork(Environment* env) : env_(env) {}
+ explicit inline ThreadPoolWork(Environment* env) : env_(env) {
+ CHECK_NOT_NULL(env);
+ }
inline virtual ~ThreadPoolWork() = default;
inline void ScheduleWork();