diff options
| author | Gabriel Schulhof <gabriel.schulhof@intel.com> | 2018-11-07 07:09:40 -0500 |
|---|---|---|
| committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2018-11-13 05:27:40 +0100 |
| commit | 0603c0a53fc7051260f3f3d3de9582bc3e6af7c9 (patch) | |
| tree | eec06e49b87c3f3668c10a2ce6bbb0e55d9a14a7 /src/node_internals.h | |
| parent | bda4643242159bb74f187614854485d9cfc31bca (diff) | |
| download | android-node-v8-0603c0a53fc7051260f3f3d3de9582bc3e6af7c9.tar.gz android-node-v8-0603c0a53fc7051260f3f3d3de9582bc3e6af7c9.tar.bz2 android-node-v8-0603c0a53fc7051260f3f3d3de9582bc3e6af7c9.zip | |
src: bundle persistent-to-local methods as class
Create a class `PersistentToLocal` which contains three methods,
`Strong`, `Weak`, and `Default`:
* `Strong` returns a `Local` from a strong persistent reference,
* `Weak` returns a `Local` from a weak persistent reference, and
* `Default` decides based on `IsWeak()` which of the above two to call.
These replace `node::StrongPersistentToLocal()`,
`node::WeakPersistentToLocal()`, and `node::PersistentToLocal()`,
respectively.
PR-URL: https://github.com/nodejs/node/pull/24276
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Diffstat (limited to 'src/node_internals.h')
| -rw-r--r-- | src/node_internals.h | 8 |
1 files changed, 0 insertions, 8 deletions
diff --git a/src/node_internals.h b/src/node_internals.h index b83c23681b..b026a96843 100644 --- a/src/node_internals.h +++ b/src/node_internals.h @@ -182,14 +182,6 @@ extern std::shared_ptr<PerProcessOptions> per_process_opts; // Forward declaration class Environment; -// If persistent.IsWeak() == false, then do not call persistent.Reset() -// while the returned Local<T> is still in scope, it will destroy the -// reference to the object. -template <class TypeName> -inline v8::Local<TypeName> PersistentToLocal( - v8::Isolate* isolate, - const Persistent<TypeName>& persistent); - // Convert a struct sockaddr to a { address: '1.2.3.4', port: 1234 } JS object. // Sets address and port properties on the info object and returns it. // If |info| is omitted, a new object is returned. |