diff options
| author | Ujjwal Sharma <usharma1998@gmail.com> | 2018-07-21 22:09:45 +0530 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2018-07-29 16:59:31 +0200 |
| commit | 35ec9b247e25b997bd4150897f15f5e76cf01779 (patch) | |
| tree | c9c346951961a7f59185797565b7048c039cad86 /src/node_i18n.cc | |
| parent | 51812ff12b9e10549725bcda57167148428e256c (diff) | |
| download | android-node-v8-35ec9b247e25b997bd4150897f15f5e76cf01779.tar.gz android-node-v8-35ec9b247e25b997bd4150897f15f5e76cf01779.tar.bz2 android-node-v8-35ec9b247e25b997bd4150897f15f5e76cf01779.zip | |
src: remove calls to deprecated v8 functions (NewFromUtf8)
Remove all calls to deprecated v8 functions (here: String::NewFromUtf8) inside
the code (src directory only).
PR-URL: https://github.com/nodejs/node/pull/21926
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src/node_i18n.cc')
| -rw-r--r-- | src/node_i18n.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/node_i18n.cc b/src/node_i18n.cc index 45871f3d3e..e6c198fb63 100644 --- a/src/node_i18n.cc +++ b/src/node_i18n.cc @@ -552,7 +552,7 @@ void GetVersion(const FunctionCallbackInfo<Value>& args) { TYPE_ICU "," TYPE_UNICODE "," TYPE_CLDR "," - TYPE_TZ)); + TYPE_TZ, v8::NewStringType::kNormal).ToLocalChecked()); } else { CHECK_GE(args.Length(), 1); CHECK(args[0]->IsString()); @@ -565,7 +565,7 @@ void GetVersion(const FunctionCallbackInfo<Value>& args) { // Success. args.GetReturnValue().Set( String::NewFromUtf8(env->isolate(), - versionString)); + versionString, v8::NewStringType::kNormal).ToLocalChecked()); } } } |