diff options
| author | Sam Roberts <vieuxtech@gmail.com> | 2019-04-09 15:21:36 -0700 |
|---|---|---|
| committer | Sam Roberts <vieuxtech@gmail.com> | 2019-04-12 12:33:37 -0700 |
| commit | 060d901f87b3d87314f8540eb02f315e2952f581 (patch) | |
| tree | 53159171201703bb6d8a4e780c8624a5c6c8cbb5 /src/node_errors.h | |
| parent | 7b0d8673898e65a368108264c77bccaa3e004028 (diff) | |
| download | android-node-v8-060d901f87b3d87314f8540eb02f315e2952f581.tar.gz android-node-v8-060d901f87b3d87314f8540eb02f315e2952f581.tar.bz2 android-node-v8-060d901f87b3d87314f8540eb02f315e2952f581.zip | |
src: replace FromJust() with Check() when possible
FromJust() is often used not for its return value, but for its
side-effects. In these cases, Check() exists, and is more clear as to
the intent. From its comment:
To be used, where the actual value of the Maybe is not needed, like
Object::Set.
See: https://github.com/nodejs/node/pull/26929/files#r269256335
PR-URL: https://github.com/nodejs/node/pull/27162
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Yongsheng Zhang <zyszys98@gmail.com>
Diffstat (limited to 'src/node_errors.h')
| -rw-r--r-- | src/node_errors.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/node_errors.h b/src/node_errors.h index 61d9b88221..4d6e1ab42d 100644 --- a/src/node_errors.h +++ b/src/node_errors.h @@ -70,7 +70,7 @@ void FatalException(v8::Isolate* isolate, v8::Exception::type(js_msg)->ToObject( \ isolate->GetCurrentContext()).ToLocalChecked(); \ e->Set(isolate->GetCurrentContext(), OneByteString(isolate, "code"), \ - js_code).FromJust(); \ + js_code).Check(); \ return e; \ } \ inline void THROW_ ## code(v8::Isolate* isolate, const char* message) { \ |