diff options
| author | Ben Noordhuis <info@bnoordhuis.nl> | 2014-10-11 16:24:12 +0200 |
|---|---|---|
| committer | Fedor Indutny <fedor@indutny.com> | 2014-10-12 02:09:16 +0400 |
| commit | 97585b0d7ab0084d90faf6bded275b902d76857a (patch) | |
| tree | 26853d875786c014e2e9ef5ed2ec18f7ed601775 /src/node_dtrace.cc | |
| parent | b2e519983f1e92a874a74c11e82027955ef8909a (diff) | |
| download | android-node-v8-97585b0d7ab0084d90faf6bded275b902d76857a.tar.gz android-node-v8-97585b0d7ab0084d90faf6bded275b902d76857a.tar.bz2 android-node-v8-97585b0d7ab0084d90faf6bded275b902d76857a.zip | |
src: remove unnecessary HandleScopes
API callback functions don't need to create a v8::HandleScope instance
because V8 already creates one in the JS->C++ adapter frame.
PR-URL: https://github.com/node-forward/node/pull/16
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Diffstat (limited to 'src/node_dtrace.cc')
| -rw-r--r-- | src/node_dtrace.cc | 6 |
1 files changed, 0 insertions, 6 deletions
diff --git a/src/node_dtrace.cc b/src/node_dtrace.cc index 6e5e31083f..ce31d483b0 100644 --- a/src/node_dtrace.cc +++ b/src/node_dtrace.cc @@ -148,7 +148,6 @@ void DTRACE_NET_SERVER_CONNECTION(const FunctionCallbackInfo<Value>& args) { if (!NODE_NET_SERVER_CONNECTION_ENABLED()) return; Environment* env = Environment::GetCurrent(args.GetIsolate()); - HandleScope scope(env->isolate()); SLURP_CONNECTION(args[0], conn); NODE_NET_SERVER_CONNECTION(&conn, conn.remote, conn.port, conn.fd); } @@ -158,7 +157,6 @@ void DTRACE_NET_STREAM_END(const FunctionCallbackInfo<Value>& args) { if (!NODE_NET_STREAM_END_ENABLED()) return; Environment* env = Environment::GetCurrent(args.GetIsolate()); - HandleScope scope(env->isolate()); SLURP_CONNECTION(args[0], conn); NODE_NET_STREAM_END(&conn, conn.remote, conn.port, conn.fd); } @@ -168,7 +166,6 @@ void DTRACE_NET_SOCKET_READ(const FunctionCallbackInfo<Value>& args) { if (!NODE_NET_SOCKET_READ_ENABLED()) return; Environment* env = Environment::GetCurrent(args.GetIsolate()); - HandleScope scope(env->isolate()); SLURP_CONNECTION(args[0], conn); if (!args[1]->IsNumber()) { @@ -184,7 +181,6 @@ void DTRACE_NET_SOCKET_WRITE(const FunctionCallbackInfo<Value>& args) { if (!NODE_NET_SOCKET_WRITE_ENABLED()) return; Environment* env = Environment::GetCurrent(args.GetIsolate()); - HandleScope scope(env->isolate()); SLURP_CONNECTION(args[0], conn); if (!args[1]->IsNumber()) { @@ -234,7 +230,6 @@ void DTRACE_HTTP_SERVER_RESPONSE(const FunctionCallbackInfo<Value>& args) { if (!NODE_HTTP_SERVER_RESPONSE_ENABLED()) return; Environment* env = Environment::GetCurrent(args.GetIsolate()); - HandleScope scope(env->isolate()); SLURP_CONNECTION(args[0], conn); NODE_HTTP_SERVER_RESPONSE(&conn, conn.remote, conn.port, conn.fd); } @@ -284,7 +279,6 @@ void DTRACE_HTTP_CLIENT_RESPONSE(const FunctionCallbackInfo<Value>& args) { if (!NODE_HTTP_CLIENT_RESPONSE_ENABLED()) return; Environment* env = Environment::GetCurrent(args.GetIsolate()); - HandleScope scope(env->isolate()); SLURP_CONNECTION_HTTP_CLIENT_RESPONSE(args[0], args[1], conn); NODE_HTTP_CLIENT_RESPONSE(&conn, conn.remote, conn.port, conn.fd); } |