diff options
| author | ssuda <sambasivarao@gmail.com> | 2012-03-21 22:17:16 +0530 |
|---|---|---|
| committer | Ben Noordhuis <info@bnoordhuis.nl> | 2012-03-23 01:02:59 +0100 |
| commit | 249c3c165ab3b93e1bd0a05668d81b289b8d4ccf (patch) | |
| tree | 95eaec927de099434f3f47ae7710c6c715bcc952 /src/node_dtrace.cc | |
| parent | e1199fa335e0cdbe11c8d2d7480409ce741d4406 (diff) | |
| download | android-node-v8-249c3c165ab3b93e1bd0a05668d81b289b8d4ccf.tar.gz android-node-v8-249c3c165ab3b93e1bd0a05668d81b289b8d4ccf.tar.bz2 android-node-v8-249c3c165ab3b93e1bd0a05668d81b289b8d4ccf.zip | |
Avoiding unnecessary ToString() calls
String::Utf8Value and String::AsciiValue constructors take Handle<Value>
So no need to convert to Handle<String>
Diffstat (limited to 'src/node_dtrace.cc')
| -rw-r--r-- | src/node_dtrace.cc | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/node_dtrace.cc b/src/node_dtrace.cc index 431a4ab319..01ea7b87fd 100644 --- a/src/node_dtrace.cc +++ b/src/node_dtrace.cc @@ -54,7 +54,7 @@ using namespace v8; return (ThrowException(Exception::Error(String::New("expected " \ "object for " #obj " to contain string member " #member)))); \ } \ - String::Utf8Value _##member(obj->Get(String::New(#member))->ToString()); \ + String::Utf8Value _##member(obj->Get(String::New(#member))); \ if ((*(const char **)valp = *_##member) == NULL) \ *(const char **)valp = "<unknown>"; @@ -203,7 +203,7 @@ Handle<Value> DTRACE_HTTP_SERVER_REQUEST(const Arguments& args) { "object for request to contain string member headers")))); Local<Value> strfwdfor = headers->Get(String::New("x-forwarded-for")); - String::Utf8Value fwdfor(strfwdfor->ToString()); + String::Utf8Value fwdfor(strfwdfor); if (!strfwdfor->IsString() || (req.forwardedFor = *fwdfor) == NULL) req.forwardedFor = const_cast<char*>(""); |