diff options
| author | Anna Henningsen <anna@addaleax.net> | 2019-10-09 01:23:18 +0200 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2019-10-11 23:09:39 +0200 |
| commit | 5c93aab278f6e09e345270b3a0fe49c591a0424f (patch) | |
| tree | 7ba5931ecb38d399154e7fb1f28975eec3bb5344 /src/node_dir.h | |
| parent | c0305af2c4aba6d6ecd39eb100a59998d87ddc69 (diff) | |
| download | android-node-v8-5c93aab278f6e09e345270b3a0fe49c591a0424f.tar.gz android-node-v8-5c93aab278f6e09e345270b3a0fe49c591a0424f.tar.bz2 android-node-v8-5c93aab278f6e09e345270b3a0fe49c591a0424f.zip | |
fs: buffer dir entries in opendir()
Read up to 32 directory entries in one batch when `dir.readSync()`
or `dir.read()` are called.
This increases performance significantly, although it introduces
quite a bit of edge case complexity.
confidence improvement accuracy (*) (**) (***)
fs/bench-opendir.js mode='async' dir='lib' n=100 *** 155.93 % ±30.05% ±40.34% ±53.21%
fs/bench-opendir.js mode='async' dir='test/parallel' n=100 *** 479.65 % ±56.81% ±76.47% ±101.32%
fs/bench-opendir.js mode='sync' dir='lib' n=100 10.38 % ±14.39% ±19.16% ±24.96%
fs/bench-opendir.js mode='sync' dir='test/parallel' n=100 *** 63.13 % ±12.84% ±17.18% ±22.58%
PR-URL: https://github.com/nodejs/node/pull/29893
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Diffstat (limited to 'src/node_dir.h')
| -rw-r--r-- | src/node_dir.h | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/node_dir.h b/src/node_dir.h index e099fe5510..03e4a06efc 100644 --- a/src/node_dir.h +++ b/src/node_dir.h @@ -25,7 +25,6 @@ class DirHandle : public AsyncWrap { static void Close(const v8::FunctionCallbackInfo<Value>& args); inline uv_dir_t* dir() { return dir_; } - AsyncWrap* GetAsyncWrap() { return this; } void MemoryInfo(MemoryTracker* tracker) const override { tracker->TrackFieldWithSize("dir", sizeof(*dir_)); @@ -46,7 +45,8 @@ class DirHandle : public AsyncWrap { void GCClose(); uv_dir_t* dir_; - uv_dirent_t dirent_; + // Up to 32 directory entries are read through a single libuv call. + uv_dirent_t dirents_[32]; bool closing_ = false; bool closed_ = false; }; |