diff options
| author | Ben Noordhuis <info@bnoordhuis.nl> | 2017-12-13 14:51:33 +0100 |
|---|---|---|
| committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2017-12-15 07:47:42 +0100 |
| commit | 98a6f63e457859be44bb76a051fc17ccf296edbf (patch) | |
| tree | 6b9306b73b00f975b0f30a33ef18c0d8a4989432 /src/node_crypto_clienthello.h | |
| parent | e989cd1faf32f0123d176a54b153219cc10e3bc7 (diff) | |
| download | android-node-v8-98a6f63e457859be44bb76a051fc17ccf296edbf.tar.gz android-node-v8-98a6f63e457859be44bb76a051fc17ccf296edbf.tar.bz2 android-node-v8-98a6f63e457859be44bb76a051fc17ccf296edbf.zip | |
src: fix -Wundefined-inline warnings
Fix compiler warnings introduced in commit 47edfd9c3c ("crypto: move
node_crypto_clienthello-inl.h to cc") by moving constructors around.
They were defined inline but depended on definitions
from `node_crypto_clienthello-inl.h`.
PR-URL: https://github.com/nodejs/node/pull/17649
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Diffstat (limited to 'src/node_crypto_clienthello.h')
| -rw-r--r-- | src/node_crypto_clienthello.h | 14 |
1 files changed, 1 insertions, 13 deletions
diff --git a/src/node_crypto_clienthello.h b/src/node_crypto_clienthello.h index 70f082b2c2..32c470677d 100644 --- a/src/node_crypto_clienthello.h +++ b/src/node_crypto_clienthello.h @@ -33,19 +33,7 @@ namespace crypto { class ClientHelloParser { public: - ClientHelloParser() : state_(kEnded), - onhello_cb_(nullptr), - onend_cb_(nullptr), - cb_arg_(nullptr), - session_size_(0), - session_id_(nullptr), - servername_size_(0), - servername_(nullptr), - ocsp_request_(0), - tls_ticket_size_(0), - tls_ticket_(nullptr) { - Reset(); - } + inline ClientHelloParser(); class ClientHello { public: |