diff options
| author | Daniel Bevenius <daniel.bevenius@gmail.com> | 2017-12-07 15:35:53 +0100 |
|---|---|---|
| committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2017-12-11 07:19:55 +0100 |
| commit | b36d4e752868741865edbc19b6a9f97a3f9221b9 (patch) | |
| tree | ff18e62ff77396f3138e8bb9559da5211d5e2c48 /src/node_crypto_bio.cc | |
| parent | 4426d75ede638aaeb6961c22ab1cfc78ccb12056 (diff) | |
| download | android-node-v8-b36d4e752868741865edbc19b6a9f97a3f9221b9.tar.gz android-node-v8-b36d4e752868741865edbc19b6a9f97a3f9221b9.tar.bz2 android-node-v8-b36d4e752868741865edbc19b6a9f97a3f9221b9.zip | |
crypto: remove BIO_set_shutdown
I've not been able to find any reason for calling
BIO_set_shutdown(bio, 1). This is done by default for the following
versions of OpenSSL:
https://github.com/openssl/openssl/blob/OpenSSL_1_1_0/
crypto/bio/bio_lib.c#L26
https://github.com/openssl/openssl/blob/OpenSSL_1_0_1/
crypto/bio/bio_lib.c#L90
https://github.com/openssl/openssl/blob/OpenSSL_1_0_2/
crypto/bio/bio_lib.c#L88
https://github.com/openssl/openssl/blob/OpenSSL_1_0_0/
crypto/bio/bio_lib.c#L90
This commit removes the call and the comment.
PR-URL: https://github.com/nodejs/node/pull/17542
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'src/node_crypto_bio.cc')
| -rw-r--r-- | src/node_crypto_bio.cc | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/src/node_crypto_bio.cc b/src/node_crypto_bio.cc index eb0500952b..526d0d4ae5 100644 --- a/src/node_crypto_bio.cc +++ b/src/node_crypto_bio.cc @@ -68,8 +68,6 @@ void NodeBIO::AssignEnvironment(Environment* env) { int NodeBIO::New(BIO* bio) { BIO_set_data(bio, new NodeBIO()); - // XXX Why am I doing it?! - BIO_set_shutdown(bio, 1); BIO_set_init(bio, 1); return 1; |