diff options
| author | gengjiawen <technicalcute@gmail.com> | 2019-03-06 09:15:22 -0500 |
|---|---|---|
| committer | Refael Ackermann <refack@gmail.com> | 2019-03-09 21:39:08 -0500 |
| commit | 6e81a959d0b1d23ecc0ae96ce969da8192ad60f9 (patch) | |
| tree | 41cd769f03b638d221e11cf8db46a90ae372dd3f /src/node_crypto_bio.cc | |
| parent | 78913393fa67fdae7a3a87ccf82093b814edcaf8 (diff) | |
| download | android-node-v8-6e81a959d0b1d23ecc0ae96ce969da8192ad60f9.tar.gz android-node-v8-6e81a959d0b1d23ecc0ae96ce969da8192ad60f9.tar.bz2 android-node-v8-6e81a959d0b1d23ecc0ae96ce969da8192ad60f9.zip | |
src: apply clang-tidy various improvement
* rewrite to default label in method ConvertUVErrorCode
* improve if condition in method PeekWritable
* remove redundant cast in node_file.cc
PR-URL: https://github.com/nodejs/node/pull/26470
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src/node_crypto_bio.cc')
| -rw-r--r-- | src/node_crypto_bio.cc | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/src/node_crypto_bio.cc b/src/node_crypto_bio.cc index 4a71338edf..2a3ed936f8 100644 --- a/src/node_crypto_bio.cc +++ b/src/node_crypto_bio.cc @@ -427,9 +427,7 @@ char* NodeBIO::PeekWritable(size_t* size) { TryAllocateForWrite(*size); size_t available = write_head_->len_ - write_head_->write_pos_; - if (*size != 0 && available > *size) - available = *size; - else + if (*size == 0 || available <= *size) *size = available; return write_head_->data_ + write_head_->write_pos_; |