summaryrefslogtreecommitdiff
path: root/src/node_contextify.cc
diff options
context:
space:
mode:
authorAnna Henningsen <anna@addaleax.net>2019-11-08 20:40:46 +0200
committerDaniel Bevenius <daniel.bevenius@gmail.com>2019-11-12 06:29:23 +0100
commite66a2acc4cb9fc09fc32d1833b89ae56468a0931 (patch)
tree2db9ffe469a2c662eda46cef848a17d39b8a3787 /src/node_contextify.cc
parentf8c069f5b88a25304ee2fc638c51464b4df196dd (diff)
downloadandroid-node-v8-e66a2acc4cb9fc09fc32d1833b89ae56468a0931.tar.gz
android-node-v8-e66a2acc4cb9fc09fc32d1833b89ae56468a0931.tar.bz2
android-node-v8-e66a2acc4cb9fc09fc32d1833b89ae56468a0931.zip
src: migrate off ArrayBuffer::GetContents
V8 deprecates `GetContents()` in favour of `GetBackingStore()`. Update our code to reflect that. V8 also deprecates `Externalize()` and `IsExternal()`; we should be able to remove all usage of this once V8 8.0 is there. PR-URL: https://github.com/nodejs/node/pull/30339 Refs: https://github.com/v8/v8/commit/bfe3d6bce734e596e312465e207bcfd55a59fe34 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michaƫl Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com>
Diffstat (limited to 'src/node_contextify.cc')
-rw-r--r--src/node_contextify.cc8
1 files changed, 4 insertions, 4 deletions
diff --git a/src/node_contextify.cc b/src/node_contextify.cc
index 2d30e0b803..46a1d7c8ef 100644
--- a/src/node_contextify.cc
+++ b/src/node_contextify.cc
@@ -697,8 +697,8 @@ void ContextifyScript::New(const FunctionCallbackInfo<Value>& args) {
ScriptCompiler::CachedData* cached_data = nullptr;
if (!cached_data_buf.IsEmpty()) {
- ArrayBuffer::Contents contents = cached_data_buf->Buffer()->GetContents();
- uint8_t* data = static_cast<uint8_t*>(contents.Data());
+ uint8_t* data = static_cast<uint8_t*>(
+ cached_data_buf->Buffer()->GetBackingStore()->Data());
cached_data = new ScriptCompiler::CachedData(
data + cached_data_buf->ByteOffset(), cached_data_buf->ByteLength());
}
@@ -1044,8 +1044,8 @@ void ContextifyContext::CompileFunction(
// Read cache from cached data buffer
ScriptCompiler::CachedData* cached_data = nullptr;
if (!cached_data_buf.IsEmpty()) {
- ArrayBuffer::Contents contents = cached_data_buf->Buffer()->GetContents();
- uint8_t* data = static_cast<uint8_t*>(contents.Data());
+ uint8_t* data = static_cast<uint8_t*>(
+ cached_data_buf->Buffer()->GetBackingStore()->Data());
cached_data = new ScriptCompiler::CachedData(
data + cached_data_buf->ByteOffset(), cached_data_buf->ByteLength());
}