diff options
| author | GauthamBanasandra <gautham.bangalore@gmail.com> | 2018-12-02 15:11:27 +0530 |
|---|---|---|
| committer | Rich Trott <rtrott@gmail.com> | 2018-12-15 09:43:03 -0800 |
| commit | 9021b0d3fcac507b335bd1117155e555adbd7c28 (patch) | |
| tree | a6e18f00961d6a6844f78fa7e3edd8bca511ec90 /src/node_config.cc | |
| parent | 06134e3598c1b3ae89d4be84466d532c249f5d9d (diff) | |
| download | android-node-v8-9021b0d3fcac507b335bd1117155e555adbd7c28.tar.gz android-node-v8-9021b0d3fcac507b335bd1117155e555adbd7c28.tar.bz2 android-node-v8-9021b0d3fcac507b335bd1117155e555adbd7c28.zip | |
src: remove icuDataDir from node config
icuDataDir seems to be redundant as it is not used anywhere.
Hence removing it.
PR-URL: https://github.com/nodejs/node/pull/24780
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Steven R Loomis <srloomis@us.ibm.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Diffstat (limited to 'src/node_config.cc')
| -rw-r--r-- | src/node_config.cc | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/src/node_config.cc b/src/node_config.cc index 1ba1fe9d27..edf738b633 100644 --- a/src/node_config.cc +++ b/src/node_config.cc @@ -49,10 +49,6 @@ static void Initialize(Local<Object> target, READONLY_TRUE_PROPERTY(target, "hasNodeOptions"); #endif - // TODO(addaleax): This seems to be an unused, private API. Remove it? - READONLY_STRING_PROPERTY(target, "icuDataDir", - per_process_opts->icu_data_dir); - #endif // NODE_HAVE_I18N_SUPPORT if (env->options()->preserve_symlinks) |