summaryrefslogtreecommitdiff
path: root/src/node_config.cc
diff options
context:
space:
mode:
authorJoyee Cheung <joyeec9h3@gmail.com>2019-01-13 01:03:49 +0800
committerJoyee Cheung <joyeec9h3@gmail.com>2019-01-16 21:54:26 +0800
commit2190d47d604641d26acc2ef6c1b6a9ad00afa193 (patch)
tree507e94bfe52a95ef8230c08e5adf23b4d2cc9d8c /src/node_config.cc
parentcd70cbcbddfe1a577d5cf3f2c1c754359a04b9a2 (diff)
downloadandroid-node-v8-2190d47d604641d26acc2ef6c1b6a9ad00afa193.tar.gz
android-node-v8-2190d47d604641d26acc2ef6c1b6a9ad00afa193.tar.bz2
android-node-v8-2190d47d604641d26acc2ef6c1b6a9ad00afa193.zip
src: remove unused `internalBinding('config')` properties
Remove the following properties: - `preserveSymlinks` - `preserveSymlinksMain` - `experimentalModules` - `userLoader` - `experimentalVMModules` - `experimentalREPLAwait` - `exposeInternals` We used to use them to pass cli option values from C++ into JS, but now the values are obtained in JS land using `require('internal/options').getOptionValue` instead so they are unused. Also removes `test/parallel/test-internal-modules-expose.js` which tests `--expose-internals`. We already have hundreds of tests depending on `--expose-internals`, they are more than enough to test the functionality of the flag. PR-URL: https://github.com/nodejs/node/pull/25463 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Refael Ackermann <refack@gmail.com>
Diffstat (limited to 'src/node_config.cc')
-rw-r--r--src/node_config.cc22
1 files changed, 0 insertions, 22 deletions
diff --git a/src/node_config.cc b/src/node_config.cc
index c244d1d9ff..555685dd45 100644
--- a/src/node_config.cc
+++ b/src/node_config.cc
@@ -69,28 +69,6 @@ static void Initialize(Local<Object> target,
#endif // NODE_HAVE_I18N_SUPPORT
- if (env->options()->preserve_symlinks)
- READONLY_TRUE_PROPERTY(target, "preserveSymlinks");
- if (env->options()->preserve_symlinks_main)
- READONLY_TRUE_PROPERTY(target, "preserveSymlinksMain");
-
- if (env->options()->experimental_modules) {
- READONLY_TRUE_PROPERTY(target, "experimentalModules");
- const std::string& userland_loader = env->options()->userland_loader;
- if (!userland_loader.empty()) {
- READONLY_STRING_PROPERTY(target, "userLoader", userland_loader);
- }
- }
-
- if (env->options()->experimental_vm_modules)
- READONLY_TRUE_PROPERTY(target, "experimentalVMModules");
-
- if (env->options()->experimental_repl_await)
- READONLY_TRUE_PROPERTY(target, "experimentalREPLAwait");
-
- if (env->options()->expose_internals)
- READONLY_TRUE_PROPERTY(target, "exposeInternals");
-
if (env->abort_on_uncaught_exception())
READONLY_TRUE_PROPERTY(target, "shouldAbortOnUncaughtException");