summaryrefslogtreecommitdiff
path: root/src/node_buffer.cc
diff options
context:
space:
mode:
authorBen Noordhuis <info@bnoordhuis.nl>2018-02-21 15:24:18 +0100
committerBen Noordhuis <info@bnoordhuis.nl>2018-02-21 15:24:18 +0100
commit992703f2b50f6b3483e9b930737d177b9e01256d (patch)
tree7d9b2752b6021d7653d426bbebdc80a437624a47 /src/node_buffer.cc
parente53275d819fb21d4bb15a27a714f134551233cf9 (diff)
downloadandroid-node-v8-992703f2b50f6b3483e9b930737d177b9e01256d.tar.gz
android-node-v8-992703f2b50f6b3483e9b930737d177b9e01256d.tar.bz2
android-node-v8-992703f2b50f6b3483e9b930737d177b9e01256d.zip
src: prevent persistent handle resource leaks
Replace v8::Persistent with node::Persistent, a specialization that resets the persistent handle on destruction. Prevents accidental resource leaks when forgetting to call .Reset() manually. I'm fairly confident this commit fixes a number of resource leaks that have gone undiagnosed so far. PR-URL: https://github.com/nodejs/node/pull/18656 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Diffstat (limited to 'src/node_buffer.cc')
-rw-r--r--src/node_buffer.cc1
1 files changed, 0 insertions, 1 deletions
diff --git a/src/node_buffer.cc b/src/node_buffer.cc
index 72776304c8..c511562b80 100644
--- a/src/node_buffer.cc
+++ b/src/node_buffer.cc
@@ -78,7 +78,6 @@ using v8::Local;
using v8::Maybe;
using v8::MaybeLocal;
using v8::Object;
-using v8::Persistent;
using v8::String;
using v8::Uint32Array;
using v8::Uint8Array;