diff options
| author | Trevor Norris <trev.norris@gmail.com> | 2013-01-22 09:09:12 -0800 |
|---|---|---|
| committer | Nathan Rajlich <nathan@tootallnate.net> | 2013-01-25 10:42:38 -0800 |
| commit | 65249ccd9bb7edae8bbaafc2e00cd25c9c5d640d (patch) | |
| tree | d8356a9dd7154b00e2d07cd964874c14bb6874dd /src/node_buffer.cc | |
| parent | 72dd3b4e2521b4913f0a44117e6b69d70786e43d (diff) | |
| download | android-node-v8-65249ccd9bb7edae8bbaafc2e00cd25c9c5d640d.tar.gz android-node-v8-65249ccd9bb7edae8bbaafc2e00cd25c9c5d640d.tar.bz2 android-node-v8-65249ccd9bb7edae8bbaafc2e00cd25c9c5d640d.zip | |
buffer: slow buffer copy compatibility fix
Fix issue where SlowBuffers couldn't be passed as target to Buffer
copy().
Also included checks to see if Argument parameters are defined before
assigning their values. This offered ~3x's performance gain.
Backport of 16bbecc from master branch. Closes #4633.
Diffstat (limited to 'src/node_buffer.cc')
| -rw-r--r-- | src/node_buffer.cc | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/src/node_buffer.cc b/src/node_buffer.cc index 4a6e836653..3f8ebefe06 100644 --- a/src/node_buffer.cc +++ b/src/node_buffer.cc @@ -412,10 +412,10 @@ Handle<Value> Buffer::Copy(const Arguments &args) { Local<Object> target = args[0]->ToObject(); char* target_data = Buffer::Data(target); size_t target_length = Buffer::Length(target); - size_t target_start = args[1]->Uint32Value(); - size_t source_start = args[2]->Uint32Value(); - size_t source_end = args[3]->IsUint32() ? args[3]->Uint32Value() - : source->length_; + size_t target_start = args[1]->IsUndefined() ? 0 : args[1]->Uint32Value(); + size_t source_start = args[2]->IsUndefined() ? 0 : args[2]->Uint32Value(); + size_t source_end = args[3]->IsUndefined() ? source->length_ + : args[3]->Uint32Value(); if (source_end < source_start) { return ThrowException(Exception::Error(String::New( |