diff options
| author | Anna Henningsen <anna@addaleax.net> | 2019-01-13 21:53:31 +0100 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2019-01-21 20:34:48 +0100 |
| commit | 30f45683aaeb1d4917fff7bc7cb2937ee89f0082 (patch) | |
| tree | 5b2be16d3daa7e3633c90eb15372cce19302cf91 /src/node_buffer.cc | |
| parent | 67080113e72b8e15423d50de3df5522f60b0d223 (diff) | |
| download | android-node-v8-30f45683aaeb1d4917fff7bc7cb2937ee89f0082.tar.gz android-node-v8-30f45683aaeb1d4917fff7bc7cb2937ee89f0082.tar.bz2 android-node-v8-30f45683aaeb1d4917fff7bc7cb2937ee89f0082.zip | |
src: remove outdated `Neuter()` call in `node_buffer.cc`
This call was introduced in 827ee498e332e3 to avoid a crash in a
later `Neuter()` call that has later been removed in ebbbc5a790db69,
rendering the original call unnecessary.
Refs: https://github.com/nodejs/node/pull/3624
Refs: https://github.com/nodejs/node/pull/5204
PR-URL: https://github.com/nodejs/node/pull/25479
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Diffstat (limited to 'src/node_buffer.cc')
| -rw-r--r-- | src/node_buffer.cc | 5 |
1 files changed, 0 insertions, 5 deletions
diff --git a/src/node_buffer.cc b/src/node_buffer.cc index ccc338f941..e602d5618e 100644 --- a/src/node_buffer.cc +++ b/src/node_buffer.cc @@ -403,11 +403,6 @@ MaybeLocal<Object> New(Environment* env, } Local<ArrayBuffer> ab = ArrayBuffer::New(env->isolate(), data, length); - // `Neuter()`ing is required here to prevent materialization of the backing - // store in v8. `nullptr` buffers are not writable, so this is semantically - // correct. - if (data == nullptr) - ab->Neuter(); MaybeLocal<Uint8Array> ui = Buffer::New(env, ab, 0, length); CallbackInfo::New(env->isolate(), ab, callback, data, hint); |