diff options
| author | cjihrig <cjihrig@gmail.com> | 2016-07-07 11:18:32 -0400 |
|---|---|---|
| committer | cjihrig <cjihrig@gmail.com> | 2016-07-08 12:02:37 -0400 |
| commit | 18ae74cf9802ff2a65f87262c71d00ba8d68d133 (patch) | |
| tree | f0b26f2bdd34b611d3bf74437f55a07714a0a64b /src/node_buffer.cc | |
| parent | 89ede72fca942e7ceffd414e795e3d2c5e09ed0a (diff) | |
| download | android-node-v8-18ae74cf9802ff2a65f87262c71d00ba8d68d133.tar.gz android-node-v8-18ae74cf9802ff2a65f87262c71d00ba8d68d133.tar.bz2 android-node-v8-18ae74cf9802ff2a65f87262c71d00ba8d68d133.zip | |
src: suppress coverity message
Coverity marked a change in 630096b as a constant expression.
However, on platforms where sizeof(int64_t) > sizeof(size_t),
this should not be the case. This commit flags the comparison
as OK to coverity.
PR-URL: https://github.com/nodejs/node/pull/7587
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Diffstat (limited to 'src/node_buffer.cc')
| -rw-r--r-- | src/node_buffer.cc | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/src/node_buffer.cc b/src/node_buffer.cc index 57bfb87de0..1ce1dd5f1f 100644 --- a/src/node_buffer.cc +++ b/src/node_buffer.cc @@ -209,6 +209,7 @@ inline MUST_USE_RESULT bool ParseArrayIndex(Local<Value> arg, // Check that the result fits in a size_t. const uint64_t kSizeMax = static_cast<uint64_t>(static_cast<size_t>(-1)); + // coverity[pointless_expression] if (static_cast<uint64_t>(tmp_i) > kSizeMax) return false; |