summaryrefslogtreecommitdiff
path: root/src/node.cc
diff options
context:
space:
mode:
authorAnna Henningsen <anna@addaleax.net>2019-03-18 13:30:49 +0100
committerRuben Bridgewater <ruben@bridgewater.de>2019-03-22 00:44:25 +0100
commitd812dbb495a2471f7835c330b49c1d8f3fa8e5c2 (patch)
tree27150b3d5fcb8ee843994d5f3a9f34e19a1438f2 /src/node.cc
parentde3b164f4fd069ecfcf496609466fdc85838c08f (diff)
downloadandroid-node-v8-d812dbb495a2471f7835c330b49c1d8f3fa8e5c2.tar.gz
android-node-v8-d812dbb495a2471f7835c330b49c1d8f3fa8e5c2.tar.bz2
android-node-v8-d812dbb495a2471f7835c330b49c1d8f3fa8e5c2.zip
src: refactor thread stopping mechanism
- Follow style guide for naming, e.g. use lower_snake_case for simple setters/getters. - For performance, use atomics instead of a mutex, and inline the corresponding getter/setter pair. PR-URL: https://github.com/nodejs/node/pull/26757 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Diffstat (limited to 'src/node.cc')
-rw-r--r--src/node.cc4
1 files changed, 2 insertions, 2 deletions
diff --git a/src/node.cc b/src/node.cc
index b42f0169de..a67c30bb01 100644
--- a/src/node.cc
+++ b/src/node.cc
@@ -838,14 +838,14 @@ inline int StartNodeWithIsolate(Isolate* isolate,
per_process::v8_platform.DrainVMTasks(isolate);
more = uv_loop_alive(env.event_loop());
- if (more && !env.GetAsyncRequest()->IsStopped()) continue;
+ if (more && !env.is_stopping()) continue;
RunBeforeExit(&env);
// Emit `beforeExit` if the loop became alive either after emitting
// event, or after running some callbacks.
more = uv_loop_alive(env.event_loop());
- } while (more == true && !env.GetAsyncRequest()->IsStopped());
+ } while (more == true && !env.is_stopping());
env.performance_state()->Mark(
node::performance::NODE_PERFORMANCE_MILESTONE_LOOP_EXIT);
}