diff options
| author | Anna Henningsen <anna@addaleax.net> | 2018-12-15 20:50:42 +0100 |
|---|---|---|
| committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2018-12-21 07:18:05 +0100 |
| commit | 8b5720833f1a48bcfe9072305682bea76f833ab4 (patch) | |
| tree | aa537a07e49a9fa679055144c07eeae5b0f56b42 /src/node.cc | |
| parent | 0461e4cd9b3d637f53dec9c6336220d69c7178b0 (diff) | |
| download | android-node-v8-8b5720833f1a48bcfe9072305682bea76f833ab4.tar.gz android-node-v8-8b5720833f1a48bcfe9072305682bea76f833ab4.tar.bz2 android-node-v8-8b5720833f1a48bcfe9072305682bea76f833ab4.zip | |
src,lib: prefer internal/options over process._foo
This addresses a couple `TODO` comments and allows us
to remove a number of underscored properties from `process`
(in a semver-major follow-up).
PR-URL: https://github.com/nodejs/node/pull/25063
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src/node.cc')
| -rw-r--r-- | src/node.cc | 12 |
1 files changed, 8 insertions, 4 deletions
diff --git a/src/node.cc b/src/node.cc index 2564b83ef9..077d9c4996 100644 --- a/src/node.cc +++ b/src/node.cc @@ -974,6 +974,7 @@ void SetupProcessObject(Environment* env, GetParentProcessId).FromJust()); // -e, --eval + // TODO(addaleax): Remove this. if (env->options()->has_eval_string) { READONLY_PROPERTY(process, "_eval", @@ -984,23 +985,27 @@ void SetupProcessObject(Environment* env, } // -p, --print + // TODO(addaleax): Remove this. if (env->options()->print_eval) { READONLY_PROPERTY(process, "_print_eval", True(env->isolate())); } // -c, --check + // TODO(addaleax): Remove this. if (env->options()->syntax_check_only) { READONLY_PROPERTY(process, "_syntax_check_only", True(env->isolate())); } // -i, --interactive + // TODO(addaleax): Remove this. if (env->options()->force_repl) { READONLY_PROPERTY(process, "_forceRepl", True(env->isolate())); } // -r, --require - std::vector<std::string> preload_modules = - std::move(env->options()->preload_modules); + // TODO(addaleax): Remove this. + const std::vector<std::string>& preload_modules = + env->options()->preload_modules; if (!preload_modules.empty()) { Local<Array> array = Array::New(env->isolate()); for (unsigned int i = 0; i < preload_modules.size(); ++i) { @@ -1013,8 +1018,6 @@ void SetupProcessObject(Environment* env, READONLY_PROPERTY(process, "_preload_modules", array); - - preload_modules.clear(); } // --no-deprecation @@ -1043,6 +1046,7 @@ void SetupProcessObject(Environment* env, #endif // NODE_NO_BROWSER_GLOBALS // --prof-process + // TODO(addaleax): Remove this. if (env->options()->prof_process) { READONLY_PROPERTY(process, "profProcess", True(env->isolate())); } |