diff options
| author | Joyee Cheung <joyeec9h3@gmail.com> | 2019-02-10 19:57:21 +0800 |
|---|---|---|
| committer | Daniel Bevenius <daniel.bevenius@gmail.com> | 2019-02-18 07:52:47 +0100 |
| commit | 45b7c98f09bca9716c20f855f38b8dd6aba66ef0 (patch) | |
| tree | 4a4acc71ee8d7512a32760ab025d8b94720a78bf /src/node.cc | |
| parent | 04c839bd8c83eb497340bcd5a15f84a1e6fe473a (diff) | |
| download | android-node-v8-45b7c98f09bca9716c20f855f38b8dd6aba66ef0.tar.gz android-node-v8-45b7c98f09bca9716c20f855f38b8dd6aba66ef0.tar.bz2 android-node-v8-45b7c98f09bca9716c20f855f38b8dd6aba66ef0.zip | |
src: use PauseOnNextJavascriptStatement to implement --inspect-brk-node
Instead of using the `debugger;` statement which is visible in the
JS source code and makes primordials.js environment-dependent.
PR-URL: https://github.com/nodejs/node/pull/26034
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src/node.cc')
| -rw-r--r-- | src/node.cc | 10 |
1 files changed, 7 insertions, 3 deletions
diff --git a/src/node.cc b/src/node.cc index 7d9075b5e0..f257495a13 100644 --- a/src/node.cc +++ b/src/node.cc @@ -249,14 +249,18 @@ MaybeLocal<Value> RunBootstrapping(Environment* env) { // Store primordials env->set_primordials(Object::New(isolate)); std::vector<Local<String>> primordials_params = { - FIXED_ONE_BYTE_STRING(isolate, "breakAtBootstrap"), env->primordials_string() }; std::vector<Local<Value>> primordials_args = { - Boolean::New(isolate, - env->options()->debug_options().break_node_first_line), env->primordials() }; + +#if HAVE_INSPECTOR + if (env->options()->debug_options().break_node_first_line) { + env->inspector_agent()->PauseOnNextJavascriptStatement( + "Break at bootstrap"); + } +#endif // HAVE_INSPECTOR MaybeLocal<Value> primordials_ret = ExecuteBootstrapper(env, "internal/bootstrap/primordials", |