summaryrefslogtreecommitdiff
path: root/src/memory_tracker.h
diff options
context:
space:
mode:
authorGabriel Schulhof <gabriel.schulhof@intel.com>2018-11-07 07:09:40 -0500
committerDaniel Bevenius <daniel.bevenius@gmail.com>2018-11-13 05:27:40 +0100
commit0603c0a53fc7051260f3f3d3de9582bc3e6af7c9 (patch)
treeeec06e49b87c3f3668c10a2ce6bbb0e55d9a14a7 /src/memory_tracker.h
parentbda4643242159bb74f187614854485d9cfc31bca (diff)
downloadandroid-node-v8-0603c0a53fc7051260f3f3d3de9582bc3e6af7c9.tar.gz
android-node-v8-0603c0a53fc7051260f3f3d3de9582bc3e6af7c9.tar.bz2
android-node-v8-0603c0a53fc7051260f3f3d3de9582bc3e6af7c9.zip
src: bundle persistent-to-local methods as class
Create a class `PersistentToLocal` which contains three methods, `Strong`, `Weak`, and `Default`: * `Strong` returns a `Local` from a strong persistent reference, * `Weak` returns a `Local` from a weak persistent reference, and * `Default` decides based on `IsWeak()` which of the above two to call. These replace `node::StrongPersistentToLocal()`, `node::WeakPersistentToLocal()`, and `node::PersistentToLocal()`, respectively. PR-URL: https://github.com/nodejs/node/pull/24276 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Diffstat (limited to 'src/memory_tracker.h')
-rw-r--r--src/memory_tracker.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/memory_tracker.h b/src/memory_tracker.h
index 1799279212..11dd2be7af 100644
--- a/src/memory_tracker.h
+++ b/src/memory_tracker.h
@@ -69,7 +69,7 @@ class NodeBIO;
* // a BaseObject or an AsyncWrap class
* bool IsRootNode() const override { return !wrapped_.IsWeak(); }
* v8::Local<v8::Object> WrappedObject() const override {
- * return node::PersistentToLocal(wrapped_);
+ * return node::PersistentToLocal::Default(wrapped_);
* }
* private:
* AnotherRetainerClass another_retainer_;