diff options
| author | Jon Moss <me@jonathanmoss.me> | 2018-12-18 15:52:09 -0500 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2019-03-08 09:25:30 +0100 |
| commit | 4697e1b0d792f50863bbbcad25a95b84e6746501 (patch) | |
| tree | ec352361e56956176ca5831c092703d36cd929c6 /src/js_stream.cc | |
| parent | 254635198ab1e6afed357c1884c1ef75eb3b8486 (diff) | |
| download | android-node-v8-4697e1b0d792f50863bbbcad25a95b84e6746501.tar.gz android-node-v8-4697e1b0d792f50863bbbcad25a95b84e6746501.tar.bz2 android-node-v8-4697e1b0d792f50863bbbcad25a95b84e6746501.zip | |
src: remove templating from StreamBase
PR-URL: https://github.com/nodejs/node/pull/25142
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src/js_stream.cc')
| -rw-r--r-- | src/js_stream.cc | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/src/js_stream.cc b/src/js_stream.cc index ae1aa7cd30..e5f4273476 100644 --- a/src/js_stream.cc +++ b/src/js_stream.cc @@ -27,6 +27,7 @@ JSStream::JSStream(Environment* env, Local<Object> obj) : AsyncWrap(env, obj, AsyncWrap::PROVIDER_JSSTREAM), StreamBase(env) { MakeWeak(); + StreamBase::AttachToObject(obj); } @@ -203,7 +204,8 @@ void JSStream::Initialize(Local<Object> target, Local<String> jsStreamString = FIXED_ONE_BYTE_STRING(env->isolate(), "JSStream"); t->SetClassName(jsStreamString); - t->InstanceTemplate()->SetInternalFieldCount(1); + t->InstanceTemplate() + ->SetInternalFieldCount(StreamBase::kStreamBaseField + 1); t->Inherit(AsyncWrap::GetConstructorTemplate(env)); env->SetProtoMethod(t, "finishWrite", Finish<WriteWrap>); @@ -211,7 +213,7 @@ void JSStream::Initialize(Local<Object> target, env->SetProtoMethod(t, "readBuffer", ReadBuffer); env->SetProtoMethod(t, "emitEOF", EmitEOF); - StreamBase::AddMethods<JSStream>(env, t); + StreamBase::AddMethods(env, t); target->Set(env->context(), jsStreamString, t->GetFunction(context).ToLocalChecked()).FromJust(); |