diff options
| author | Anna Henningsen <anna@addaleax.net> | 2019-11-13 19:19:54 +0000 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2019-11-19 14:01:32 +0100 |
| commit | 6cb8e4b12cd16ae8ed126f98458efb78312cabf6 (patch) | |
| tree | e37ef2d4f2104f6f51479ea78c63e6f890cea7c0 /src/js_native_api_v8.h | |
| parent | 1317ac65b4f001588b86002aa22431719683beb4 (diff) | |
| download | android-node-v8-6cb8e4b12cd16ae8ed126f98458efb78312cabf6.tar.gz android-node-v8-6cb8e4b12cd16ae8ed126f98458efb78312cabf6.tar.bz2 android-node-v8-6cb8e4b12cd16ae8ed126f98458efb78312cabf6.zip | |
src: mark ArrayBuffers with free callbacks as untransferable
More precisely, make them untransferable if they were created through
*our* APIs, because those do not follow the improved free callback
mechanism that V8 uses now. All other ArrayBuffers can be transferred
between threads now, the assumption being that they were created in a
clean way that follows the V8 API on this.
This addresses a TODO comment.
Refs: https://github.com/nodejs/node/pull/30339#issuecomment-552225353
PR-URL: https://github.com/nodejs/node/pull/30475
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Diffstat (limited to 'src/js_native_api_v8.h')
| -rw-r--r-- | src/js_native_api_v8.h | 4 |
1 files changed, 4 insertions, 0 deletions
diff --git a/src/js_native_api_v8.h b/src/js_native_api_v8.h index 2e0a7a1d6a..534b09851f 100644 --- a/src/js_native_api_v8.h +++ b/src/js_native_api_v8.h @@ -39,6 +39,10 @@ struct napi_env__ { inline void Unref() { if ( --refs == 0) delete this; } virtual bool can_call_into_js() const { return true; } + virtual v8::Maybe<bool> mark_arraybuffer_as_untransferable( + v8::Local<v8::ArrayBuffer> ab) const { + return v8::Just(true); + } template <typename T, typename U> void CallIntoModule(T&& call, U&& handle_exception) { |