diff options
| author | Ben Noordhuis <info@bnoordhuis.nl> | 2019-02-08 14:34:43 +0100 |
|---|---|---|
| committer | Ruben Bridgewater <ruben@bridgewater.de> | 2019-03-04 02:19:27 +0100 |
| commit | df67cd0fef65f8988e5189769e6e6fc3fb0aa716 (patch) | |
| tree | bad64b08153f5da5cea835bb2c7c2bc2bfdfa063 /src/inspector_socket_server.h | |
| parent | 000788ec23c584c3ded71dae5cab057de0f416bd (diff) | |
| download | android-node-v8-df67cd0fef65f8988e5189769e6e6fc3fb0aa716.tar.gz android-node-v8-df67cd0fef65f8988e5189769e6e6fc3fb0aa716.tar.bz2 android-node-v8-df67cd0fef65f8988e5189769e6e6fc3fb0aa716.zip | |
inspector: print all listening addresses
Some hostnames have multiple interfaces. Before this commit, the
inspector only printed the first one. Now, it prints them all.
No test. I can't think of a reliable way to test this on the CI matrix.
PR-URL: https://github.com/nodejs/node/pull/26008
Fixes: https://github.com/nodejs/node/issues/13772
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src/inspector_socket_server.h')
| -rw-r--r-- | src/inspector_socket_server.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/inspector_socket_server.h b/src/inspector_socket_server.h index 5c61b4e5ee..082de54ac6 100644 --- a/src/inspector_socket_server.h +++ b/src/inspector_socket_server.h @@ -73,10 +73,10 @@ class InspectorSocketServer { return server_sockets_.empty() && connected_sessions_.empty(); } - private: static void CloseServerSocket(ServerSocket*); using ServerSocketPtr = DeleteFnPtr<ServerSocket, CloseServerSocket>; + private: void SendListResponse(InspectorSocket* socket, const std::string& host, SocketSession* session); std::string GetFrontendURL(bool is_compat, |