diff options
author | Eugene Ostroukhov <eostroukhov@gmail.com> | 2019-07-03 11:32:31 -0700 |
---|---|---|
committer | Anna Henningsen <anna@addaleax.net> | 2019-07-06 20:04:03 +0200 |
commit | 17862fca5f6acfad5941ec651769493310a5c571 (patch) | |
tree | 203ae2d3a759a5b47244d1ae048ebbf7997de0f3 /src/inspector_io.h | |
parent | 33a8093411e984756869ab03226b21bdecd85795 (diff) | |
download | android-node-v8-17862fca5f6acfad5941ec651769493310a5c571.tar.gz android-node-v8-17862fca5f6acfad5941ec651769493310a5c571.tar.bz2 android-node-v8-17862fca5f6acfad5941ec651769493310a5c571.zip |
inspector: reduce InspectorIo API surface
This is a cleanup, allowing for a better separation of concerns.
PR-URL: https://github.com/nodejs/node/pull/28526
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Aleksei Koziatinskii <ak239spb@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Diffstat (limited to 'src/inspector_io.h')
-rw-r--r-- | src/inspector_io.h | 22 |
1 files changed, 1 insertions, 21 deletions
diff --git a/src/inspector_io.h b/src/inspector_io.h index 57facb2294..e9f9405673 100644 --- a/src/inspector_io.h +++ b/src/inspector_io.h @@ -14,32 +14,14 @@ #include <cstddef> #include <memory> - -namespace v8_inspector { -class StringBuffer; -class StringView; -} // namespace v8_inspector - namespace node { // Forward declaration to break recursive dependency chain with src/env.h. class Environment; namespace inspector { -std::string FormatWsAddress(const std::string& host, int port, - const std::string& target_id, - bool include_protocol); - -class InspectorIoDelegate; class MainThreadHandle; class RequestQueue; -// kKill closes connections and stops the server, kStop only stops the server -enum class TransportAction { - kKill, - kSendMessage, - kStop -}; - class InspectorIo { public: // Start the inspector agent thread, waiting for it to initialize @@ -55,9 +37,7 @@ class InspectorIo { ~InspectorIo(); void StopAcceptingNewConnections(); - const std::string& host() const { return host_port_->host(); } - int port() const { return host_port_->port(); } - std::vector<std::string> GetTargetIds() const; + std::string GetWsUrl() const; private: InspectorIo(std::shared_ptr<MainThreadHandle> handle, |