diff options
| author | Matt Loring <mattloring@google.com> | 2017-03-13 15:17:57 -0700 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2017-08-17 20:26:55 +0200 |
| commit | 9e08695f85d4273f01e010cf384f42030d66b453 (patch) | |
| tree | 24e9bc7ba9c4e2784cb18b3d692ef227b9de4e28 /src/inspector_agent.h | |
| parent | 5e5a52fc937d53b5bcf5c2c09c898d8311db2bca (diff) | |
| download | android-node-v8-9e08695f85d4273f01e010cf384f42030d66b453.tar.gz android-node-v8-9e08695f85d4273f01e010cf384f42030d66b453.tar.bz2 android-node-v8-9e08695f85d4273f01e010cf384f42030d66b453.zip | |
src: Node implementation of v8::Platform
Node.js currently uses the V8 implementation of the DefaultPlatform
which schedules VM tasks on a V8 managed thread pool. Since the Node.js
event loop is not aware of these tasks, the Node.js process may exit
while there are outstanding VM tasks. This will become problematic once
asynchronous wasm compilation lands in V8.
This PR introduces a Node.js specific implementation of the v8::Platform
on top of libuv so that the event loop is aware of outstanding VM tasks.
PR-URL: https://github.com/nodejs/node/pull/14001
Fixes: https://github.com/nodejs/node/issues/3665
Fixes: https://github.com/nodejs/node/issues/8496
Fixes: https://github.com/nodejs/node/issues/12980
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Diffstat (limited to 'src/inspector_agent.h')
| -rw-r--r-- | src/inspector_agent.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/inspector_agent.h b/src/inspector_agent.h index 6ec1bc28dc..8195e001c2 100644 --- a/src/inspector_agent.h +++ b/src/inspector_agent.h @@ -14,6 +14,7 @@ // Forward declaration to break recursive dependency chain with src/env.h. namespace node { class Environment; +class NodePlatform; } // namespace node #include "v8.h" @@ -42,7 +43,7 @@ class Agent { ~Agent(); // Create client_, may create io_ if option enabled - bool Start(v8::Platform* platform, const char* path, + bool Start(node::NodePlatform* platform, const char* path, const DebugOptions& options); // Stop and destroy io_ void Stop(); |