diff options
| author | Tom Boutell <tom@punkave.com> | 2017-10-06 11:30:48 -0700 |
|---|---|---|
| committer | Tobias Nießen <tniessen@tnie.de> | 2017-10-28 21:50:46 +0200 |
| commit | 2e8c04b1bb3fd9e735b26ff0de2f18d8e9c7099c (patch) | |
| tree | 512335ee9eedf94d34e2e633b39ce09e946cf147 /src/inspector_agent.cc | |
| parent | 6a7210edcf4621f65c73e442ff7d0cb9ebe43bd3 (diff) | |
| download | android-node-v8-2e8c04b1bb3fd9e735b26ff0de2f18d8e9c7099c.tar.gz android-node-v8-2e8c04b1bb3fd9e735b26ff0de2f18d8e9c7099c.tar.bz2 android-node-v8-2e8c04b1bb3fd9e735b26ff0de2f18d8e9c7099c.zip | |
src: use maybe versions of methods
PR-URL: https://github.com/nodejs/node/pull/16005
Fixes: https://github.com/nodejs/node/issues/15864
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Diffstat (limited to 'src/inspector_agent.cc')
| -rw-r--r-- | src/inspector_agent.cc | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/src/inspector_agent.cc b/src/inspector_agent.cc index 4828fa3071..beaebde1c3 100644 --- a/src/inspector_agent.cc +++ b/src/inspector_agent.cc @@ -496,11 +496,11 @@ bool Agent::StartIoThread(bool wait_for_connect) { v8::Isolate* isolate = parent_env_->isolate(); HandleScope handle_scope(isolate); + auto context = parent_env_->context(); // Enable tracking of async stack traces if (!enable_async_hook_function_.IsEmpty()) { Local<Function> enable_fn = enable_async_hook_function_.Get(isolate); - auto context = parent_env_->context(); auto result = enable_fn->Call(context, Undefined(isolate), 0, nullptr); if (result.IsEmpty()) { FatalError( @@ -512,14 +512,15 @@ bool Agent::StartIoThread(bool wait_for_connect) { // Send message to enable debug in workers Local<Object> process_object = parent_env_->process_object(); Local<Value> emit_fn = - process_object->Get(FIXED_ONE_BYTE_STRING(isolate, "emit")); + process_object->Get(context, FIXED_ONE_BYTE_STRING(isolate, "emit")) + .ToLocalChecked(); // In case the thread started early during the startup if (!emit_fn->IsFunction()) return true; Local<Object> message = Object::New(isolate); - message->Set(FIXED_ONE_BYTE_STRING(isolate, "cmd"), - FIXED_ONE_BYTE_STRING(isolate, "NODE_DEBUG_ENABLED")); + message->Set(context, FIXED_ONE_BYTE_STRING(isolate, "cmd"), + FIXED_ONE_BYTE_STRING(isolate, "NODE_DEBUG_ENABLED")).FromJust(); Local<Value> argv[] = { FIXED_ONE_BYTE_STRING(isolate, "internalMessage"), message |