diff options
| author | Jeremiah Senkpiel <fishrock123@rocketmail.com> | 2016-04-14 18:55:34 -0400 |
|---|---|---|
| committer | Jeremiah Senkpiel <fishrock123@rocketmail.com> | 2016-04-25 18:17:40 -0400 |
| commit | 9bb5a5e2a127010807f5b8a8bf4cf34109271c55 (patch) | |
| tree | 568dd135433a45fe4d4b8ee9ea60502c79a889c3 /src/handle_wrap.h | |
| parent | eb4201f07a1b1f430ddf4efad4f276f3088def97 (diff) | |
| download | android-node-v8-9bb5a5e2a127010807f5b8a8bf4cf34109271c55.tar.gz android-node-v8-9bb5a5e2a127010807f5b8a8bf4cf34109271c55.tar.bz2 android-node-v8-9bb5a5e2a127010807f5b8a8bf4cf34109271c55.zip | |
handle_wrap: IsRefed -> Unrefed, no isAlive check
This fixes my perceived usability issues with 7d8882b. Which, at the
time of writing, has not landed in any release except v6 RCs. This
should not be considered a breaking change due to that.
It is useful if you have a handle, even if it has been closed, to be
able to inspect whether that handle was unrefed or not. As such, this
renames the method accordingly. If people need to check a handle's
aliveness, that is a separate API we should consider exposing.
Refs: https://github.com/nodejs/node/pull/5834
PR-URL: https://github.com/nodejs/node/pull/6204
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Diffstat (limited to 'src/handle_wrap.h')
| -rw-r--r-- | src/handle_wrap.h | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/handle_wrap.h b/src/handle_wrap.h index cb3ba3f5d5..d945143d31 100644 --- a/src/handle_wrap.h +++ b/src/handle_wrap.h @@ -35,7 +35,7 @@ class HandleWrap : public AsyncWrap { static void Close(const v8::FunctionCallbackInfo<v8::Value>& args); static void Ref(const v8::FunctionCallbackInfo<v8::Value>& args); static void Unref(const v8::FunctionCallbackInfo<v8::Value>& args); - static void IsRefed(const v8::FunctionCallbackInfo<v8::Value>& args); + static void Unrefed(const v8::FunctionCallbackInfo<v8::Value>& args); static inline bool IsAlive(const HandleWrap* wrap) { return wrap != nullptr && wrap->GetHandle() != nullptr; |