Move HandleWrap rules to one place

1 files changed, 20 insertions, 0 deletions

diff --git a/src/handle_wrap.h b/src/handle_wrap.h
index 2c51799a58..8329da0417 100644
--- a/src/handle_wrap.h
+++ b/src/handle_wrap.h
@@ -3,6 +3,26 @@
 
 namespace node {
 
+// Rules:
+//
+// - Do not throw from handle methods. Set errno.
+//
+// - MakeCallback may only be made directly off the event loop.
+//   That is there can be no JavaScript stack frames underneith it.
+//   (Is there anyway to assert that?)
+//
+// - No use of v8::WeakReferenceCallback. The close callback signifies that
+//   we're done with a handle - external resources can be freed.
+//
+// - Reusable?
+//
+// - The uv_close_cb is used to free the c++ object. The close callback
+//   is not made into javascript land.
+//
+// - uv_ref, uv_unref counts are managed at this layer to avoid needless
+//   js/c++ boundary crossing. At the javascript layer that should all be
+//   taken care of.
+
 class HandleWrap {
   public:
     static void Initialize(v8::Handle<v8::Object> target);