diff options
| author | Anna Henningsen <anna@addaleax.net> | 2018-03-24 23:12:22 +0100 |
|---|---|---|
| committer | Anna Henningsen <anna@addaleax.net> | 2018-05-10 14:15:18 +0200 |
| commit | 2b3150466e5f4db841f5980cda32172555bdda15 (patch) | |
| tree | fd68fdd08feb9681f5ab05d5716f484acb9d796a /src/handle_wrap.h | |
| parent | 5d7045960628084f79f5da74272000b7d0b8256f (diff) | |
| download | android-node-v8-2b3150466e5f4db841f5980cda32172555bdda15.tar.gz android-node-v8-2b3150466e5f4db841f5980cda32172555bdda15.tar.bz2 android-node-v8-2b3150466e5f4db841f5980cda32172555bdda15.zip | |
src: always call ReadStop() before Close()
For libuv-backed streams, always explicitly stop reading before
closing the handle.
PR-URL: https://github.com/nodejs/node/pull/19377
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src/handle_wrap.h')
| -rw-r--r-- | src/handle_wrap.h | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/handle_wrap.h b/src/handle_wrap.h index fd2d002dce..b2b09f5010 100644 --- a/src/handle_wrap.h +++ b/src/handle_wrap.h @@ -70,7 +70,8 @@ class HandleWrap : public AsyncWrap { inline uv_handle_t* GetHandle() const { return handle_; } - void Close(v8::Local<v8::Value> close_callback = v8::Local<v8::Value>()); + virtual void Close( + v8::Local<v8::Value> close_callback = v8::Local<v8::Value>()); protected: HandleWrap(Environment* env, |