diff options
author | Joyee Cheung <joyeec9h3@gmail.com> | 2018-02-09 03:34:50 +0800 |
---|---|---|
committer | Joyee Cheung <joyeec9h3@gmail.com> | 2018-02-14 03:55:15 -0500 |
commit | 18d23aa36e7f91bbc8dc6eb5972d2663a3a3df35 (patch) | |
tree | 8f4197a87507e31f26f63ceea3f38df580a968de /src/handle_wrap.h | |
parent | e9ba0cfd46d75d21e9e2359e40710c3ee46a296a (diff) | |
download | android-node-v8-18d23aa36e7f91bbc8dc6eb5972d2663a3a3df35.tar.gz android-node-v8-18d23aa36e7f91bbc8dc6eb5972d2663a3a3df35.tar.bz2 android-node-v8-18d23aa36e7f91bbc8dc6eb5972d2663a3a3df35.zip |
src: do not redefine private for GenDebugSymbols
Redefining private breaks any private inheritance in the
included files. We can simply declare GenDebugSymbols()
as friends in related classes to gain the access that we need.
PR-URL: https://github.com/nodejs/node/pull/18653
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src/handle_wrap.h')
-rw-r--r-- | src/handle_wrap.h | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/src/handle_wrap.h b/src/handle_wrap.h index 1cfe3e2ebb..19fd36891a 100644 --- a/src/handle_wrap.h +++ b/src/handle_wrap.h @@ -81,11 +81,13 @@ class HandleWrap : public AsyncWrap { friend class Environment; friend void GetActiveHandles(const v8::FunctionCallbackInfo<v8::Value>&); static void OnClose(uv_handle_t* handle); + // handle_wrap_queue_ needs to be at a fixed offset from the start of the // class because it is used by src/node_postmortem_metadata.cc to calculate // offsets and generate debug symbols for HandleWrap, which assumes that the // position of members in memory are predictable. For more information please // refer to `doc/guides/node-postmortem-support.md` + friend int GenDebugSymbols(); ListNode<HandleWrap> handle_wrap_queue_; enum { kInitialized, kClosing, kClosingWithCallback, kClosed } state_; uv_handle_t* const handle_; |