summaryrefslogtreecommitdiff
path: root/src/handle_wrap.h
diff options
context:
space:
mode:
authorBen Noordhuis <info@bnoordhuis.nl>2013-07-03 04:23:44 +0200
committerBen Noordhuis <info@bnoordhuis.nl>2013-07-06 17:44:44 +0200
commit110a9cd8db515c4d1a9ac5cd8837291da7c6c5ea (patch)
tree71e5a14a98131d89d670f842eb36bfcccab00b7b /src/handle_wrap.h
parent9b3de60d3537df657e75887436a5b1df5ed80c2d (diff)
downloadandroid-node-v8-110a9cd8db515c4d1a9ac5cd8837291da7c6c5ea.tar.gz
android-node-v8-110a9cd8db515c4d1a9ac5cd8837291da7c6c5ea.tar.bz2
android-node-v8-110a9cd8db515c4d1a9ac5cd8837291da7c6c5ea.zip
lib, src: upgrade after v8 api change
This is a big commit that touches just about every file in the src/ directory. The V8 API has changed in significant ways. The most important changes are: * Binding functions take a const v8::FunctionCallbackInfo<T>& argument rather than a const v8::Arguments& argument. * Binding functions return void rather than v8::Handle<v8::Value>. The return value is returned with the args.GetReturnValue().Set() family of functions. * v8::Persistent<T> no longer derives from v8::Handle<T> and no longer allows you to directly dereference the object that the persistent handle points to. This means that the common pattern of caching oft-used JS values in a persistent handle no longer quite works, you first need to reconstruct a v8::Local<T> from the persistent handle with the Local<T>::New(isolate, persistent) factory method. A handful of (internal) convenience classes and functions have been added to make dealing with the new API a little easier. The most visible one is node::Cached<T>, which wraps a v8::Persistent<T> with some template sugar. It can hold arbitrary types but so far it's exclusively used for v8::Strings (which was by far the most commonly cached handle type.)
Diffstat (limited to 'src/handle_wrap.h')
-rw-r--r--src/handle_wrap.h57
1 files changed, 32 insertions, 25 deletions
diff --git a/src/handle_wrap.h b/src/handle_wrap.h
index 3a42148a62..d8194b97b0 100644
--- a/src/handle_wrap.h
+++ b/src/handle_wrap.h
@@ -53,31 +53,38 @@ namespace node {
args.This()->GetAlignedPointerFromInternalField(0));
class HandleWrap {
- public:
- static void Initialize(v8::Handle<v8::Object> target);
- static v8::Handle<v8::Value> Close(const v8::Arguments& args);
- static v8::Handle<v8::Value> Ref(const v8::Arguments& args);
- static v8::Handle<v8::Value> Unref(const v8::Arguments& args);
-
- inline uv_handle_t* GetHandle() { return handle__; };
-
- protected:
- HandleWrap(v8::Handle<v8::Object> object, uv_handle_t* handle);
- virtual ~HandleWrap();
-
- v8::Persistent<v8::Object> object_;
-
- private:
- friend v8::Handle<v8::Value> GetActiveHandles(const v8::Arguments&);
- static void OnClose(uv_handle_t* handle);
- QUEUE handle_wrap_queue_;
- // Using double underscore due to handle_ member in tcp_wrap. Probably
- // tcp_wrap should rename it's member to 'handle'.
- uv_handle_t* handle__;
- unsigned int flags_;
-
- static const unsigned int kUnref = 1;
- static const unsigned int kCloseCallback = 2;
+public:
+ static void Initialize(v8::Handle<v8::Object> target);
+ static void Close(const v8::FunctionCallbackInfo<v8::Value>& args);
+ static void Ref(const v8::FunctionCallbackInfo<v8::Value>& args);
+ static void Unref(const v8::FunctionCallbackInfo<v8::Value>& args);
+
+ inline uv_handle_t* GetHandle() { return handle__; };
+
+protected:
+ HandleWrap(v8::Handle<v8::Object> object, uv_handle_t* handle);
+ virtual ~HandleWrap();
+
+ inline v8::Local<v8::Object> object() {
+ return v8::Local<v8::Object>::New(node_isolate, persistent());
+ }
+
+ inline v8::Persistent<v8::Object>& persistent() {
+ return object_;
+ }
+
+private:
+ friend void GetActiveHandles(const v8::FunctionCallbackInfo<v8::Value>&);
+ static void OnClose(uv_handle_t* handle);
+ v8::Persistent<v8::Object> object_;
+ QUEUE handle_wrap_queue_;
+ // Using double underscore due to handle_ member in tcp_wrap. Probably
+ // tcp_wrap should rename it's member to 'handle'.
+ uv_handle_t* handle__;
+ unsigned int flags_;
+
+ static const unsigned int kUnref = 1;
+ static const unsigned int kCloseCallback = 2;
};