diff options
| author | Jeremiah Senkpiel <fishrock123@rocketmail.com> | 2016-04-14 18:55:34 -0400 |
|---|---|---|
| committer | Jeremiah Senkpiel <fishrock123@rocketmail.com> | 2016-04-25 18:17:40 -0400 |
| commit | 9bb5a5e2a127010807f5b8a8bf4cf34109271c55 (patch) | |
| tree | 568dd135433a45fe4d4b8ee9ea60502c79a889c3 /src/handle_wrap.cc | |
| parent | eb4201f07a1b1f430ddf4efad4f276f3088def97 (diff) | |
| download | android-node-v8-9bb5a5e2a127010807f5b8a8bf4cf34109271c55.tar.gz android-node-v8-9bb5a5e2a127010807f5b8a8bf4cf34109271c55.tar.bz2 android-node-v8-9bb5a5e2a127010807f5b8a8bf4cf34109271c55.zip | |
handle_wrap: IsRefed -> Unrefed, no isAlive check
This fixes my perceived usability issues with 7d8882b. Which, at the
time of writing, has not landed in any release except v6 RCs. This
should not be considered a breaking change due to that.
It is useful if you have a handle, even if it has been closed, to be
able to inspect whether that handle was unrefed or not. As such, this
renames the method accordingly. If people need to check a handle's
aliveness, that is a separate API we should consider exposing.
Refs: https://github.com/nodejs/node/pull/5834
PR-URL: https://github.com/nodejs/node/pull/6204
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Diffstat (limited to 'src/handle_wrap.cc')
| -rw-r--r-- | src/handle_wrap.cc | 6 |
1 files changed, 3 insertions, 3 deletions
diff --git a/src/handle_wrap.cc b/src/handle_wrap.cc index 7a7ce8ae26..8421d694a9 100644 --- a/src/handle_wrap.cc +++ b/src/handle_wrap.cc @@ -37,11 +37,11 @@ void HandleWrap::Unref(const FunctionCallbackInfo<Value>& args) { } -void HandleWrap::IsRefed(const FunctionCallbackInfo<Value>& args) { +void HandleWrap::Unrefed(const FunctionCallbackInfo<Value>& args) { HandleWrap* wrap = Unwrap<HandleWrap>(args.Holder()); - bool refed = IsAlive(wrap) && (wrap->flags_ & kUnref) == 0; - args.GetReturnValue().Set(refed); + bool unrefed = wrap->flags_ & kUnref == 1; + args.GetReturnValue().Set(unrefed); } |