diff options
| author | Anatoli Papirovski <apapirovski@mac.com> | 2018-01-19 15:42:59 -0500 |
|---|---|---|
| committer | Anatoli Papirovski <apapirovski@mac.com> | 2018-01-29 11:37:29 -0500 |
| commit | eeede3b19c8bdb78605764eec75bea327c9014ff (patch) | |
| tree | f57709e12c4e7e9562951bb07042f0023925a441 /src/env.h | |
| parent | e4743ab61929bcccc729165e74eb6d6b3ef25135 (diff) | |
| download | android-node-v8-eeede3b19c8bdb78605764eec75bea327c9014ff.tar.gz android-node-v8-eeede3b19c8bdb78605764eec75bea327c9014ff.tar.bz2 android-node-v8-eeede3b19c8bdb78605764eec75bea327c9014ff.zip | |
domain: further abstract usage in C++
Move the majority of C++ domain-related code into JS land by introducing
a top level domain callback which handles entering & exiting the domain.
Move the rest of the domain necessities into their own file that creates
an internal binding, to avoid exposing domain-related code on the
process object.
Modify an existing test slightly to better test domain-related code.
PR-URL: https://github.com/nodejs/node/pull/18291
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src/env.h')
| -rw-r--r-- | src/env.h | 7 |
1 files changed, 1 insertions, 6 deletions
@@ -91,7 +91,6 @@ class ModuleWrap; V(decorated_private_symbol, "node:decorated") \ V(npn_buffer_private_symbol, "node:npnBuffer") \ V(selected_npn_buffer_private_symbol, "node:selectedNpnBuffer") \ - V(domain_private_symbol, "node:domain") \ // Strings are per-isolate primitives but Environment proxies them // for the sake of convenience. Strings should be ASCII-only. @@ -128,7 +127,6 @@ class ModuleWrap; V(dns_soa_string, "SOA") \ V(dns_srv_string, "SRV") \ V(dns_txt_string, "TXT") \ - V(domain_string, "domain") \ V(emit_warning_string, "emitWarning") \ V(exchange_string, "exchange") \ V(encoding_string, "encoding") \ @@ -280,6 +278,7 @@ class ModuleWrap; V(internal_binding_cache_object, v8::Object) \ V(buffer_prototype_object, v8::Object) \ V(context, v8::Context) \ + V(domain_callback, v8::Function) \ V(host_import_module_dynamically_callback, v8::Function) \ V(http2ping_constructor_template, v8::ObjectTemplate) \ V(http2stream_constructor_template, v8::ObjectTemplate) \ @@ -567,9 +566,6 @@ class Environment { inline IsolateData* isolate_data() const; - inline bool using_domains() const; - inline void set_using_domains(bool value); - inline bool printed_error() const; inline void set_printed_error(bool value); @@ -745,7 +741,6 @@ class Environment { ImmediateInfo immediate_info_; TickInfo tick_info_; const uint64_t timer_base_; - bool using_domains_; bool printed_error_; bool trace_sync_io_; bool abort_on_uncaught_exception_; |