diff options
author | Anna Henningsen <anna@addaleax.net> | 2019-02-21 19:22:44 +0100 |
---|---|---|
committer | Anna Henningsen <anna@addaleax.net> | 2019-03-01 22:46:24 +0100 |
commit | d64e4deb737a91654ff683d6cc00d0419374df5e (patch) | |
tree | 39491b1cd32d679b1003c17f84b77016c4ad740d /src/env.h | |
parent | 018e95ad13f431293c9a79dd8a2da4a8a67b81c1 (diff) | |
download | android-node-v8-d64e4deb737a91654ff683d6cc00d0419374df5e.tar.gz android-node-v8-d64e4deb737a91654ff683d6cc00d0419374df5e.tar.bz2 android-node-v8-d64e4deb737a91654ff683d6cc00d0419374df5e.zip |
src: simplify native immediate by using v8::Global
Unlike `node::Persistent`, `v8::Global` has move semantics and
can be used directly in STL containers.
PR-URL: https://github.com/nodejs/node/pull/26254
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Diffstat (limited to 'src/env.h')
-rw-r--r-- | src/env.h | 2 |
1 files changed, 1 insertions, 1 deletions
@@ -1139,7 +1139,7 @@ class Environment { struct NativeImmediateCallback { native_immediate_callback cb_; void* data_; - std::unique_ptr<Persistent<v8::Object>> keep_alive_; + v8::Global<v8::Object> keep_alive_; bool refed_; }; std::vector<NativeImmediateCallback> native_immediate_callbacks_; |