summaryrefslogtreecommitdiff
path: root/src/env.h
diff options
context:
space:
mode:
authorJoyee Cheung <joyeec9h3@gmail.com>2019-01-15 21:57:29 +0800
committerJoyee Cheung <joyeec9h3@gmail.com>2019-01-23 20:23:23 +0800
commitd3806f9f3cded6bce9831f5d8ff88372ba7e5861 (patch)
tree0ee4ee76357220d88fd44c2bf3f782e34b5cd957 /src/env.h
parenta93c825d7843e72d3e534939639f49ce8e26b16b (diff)
downloadandroid-node-v8-d3806f9f3cded6bce9831f5d8ff88372ba7e5861.tar.gz
android-node-v8-d3806f9f3cded6bce9831f5d8ff88372ba7e5861.tar.bz2
android-node-v8-d3806f9f3cded6bce9831f5d8ff88372ba7e5861.zip
console: refactor inspector console extension installation
- Instead of creating the console extensions eagerly during bootstrap and storing them on an object, wrap the code into a function to be called during `installAdditionalCommandLineAPI` only when the extensions are actually needed, which may not even happen if the user do not use the console in an inspector session, and does not need to happen during bootstrap unconditionally. - Simplify the console methods wrapping and move the `consoleFromVM` storage to `internal/util/inspector.js` PR-URL: https://github.com/nodejs/node/pull/25450 Reviewed-By: John-David Dalton <john.david.dalton@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Diffstat (limited to 'src/env.h')
-rw-r--r--src/env.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/env.h b/src/env.h
index 711d07963a..9de45a464b 100644
--- a/src/env.h
+++ b/src/env.h
@@ -356,7 +356,7 @@ constexpr size_t kFsStatsBufferLength = kFsStatsFieldsNumber * 2;
V(http2settings_constructor_template, v8::ObjectTemplate) \
V(http2stream_constructor_template, v8::ObjectTemplate) \
V(immediate_callback_function, v8::Function) \
- V(inspector_console_api_object, v8::Object) \
+ V(inspector_console_extension_installer, v8::Function) \
V(libuv_stream_wrap_ctor_template, v8::FunctionTemplate) \
V(message_port, v8::Object) \
V(message_port_constructor_template, v8::FunctionTemplate) \