diff options
author | Anna Henningsen <anna@addaleax.net> | 2019-03-10 22:03:15 +0000 |
---|---|---|
committer | Anna Henningsen <anna@addaleax.net> | 2019-03-21 19:09:45 +0100 |
commit | 96c3224de0e938d308ab579e4cf7336e87c67d88 (patch) | |
tree | 3f556d5c7bfb5d9be23fb20c8ebe0514a33a5d5e /src/env.h | |
parent | 1500e5de64e4f7cfb482ad353293645a5599d93f (diff) | |
download | android-node-v8-96c3224de0e938d308ab579e4cf7336e87c67d88.tar.gz android-node-v8-96c3224de0e938d308ab579e4cf7336e87c67d88.tar.bz2 android-node-v8-96c3224de0e938d308ab579e4cf7336e87c67d88.zip |
src: remove `AddPromiseHook()`
Remove this, as the underlying `Isolate::SetPromiseHook()` may be
removed as well in its current form in the future, and `async_hooks`
also serves this use case.
Refs: https://docs.google.com/document/d/1g8OrG5lMIUhRn1zbkutgY83MiTSMx-0NHDs8Bf-nXxM/
Refs: https://github.com/nodejs/node/pull/26529
PR-URL: https://github.com/nodejs/node/pull/26574
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Diffstat (limited to 'src/env.h')
-rw-r--r-- | src/env.h | 13 |
1 files changed, 0 insertions, 13 deletions
@@ -959,8 +959,6 @@ class Environment { inline HandleWrapQueue* handle_wrap_queue() { return &handle_wrap_queue_; } inline ReqWrapQueue* req_wrap_queue() { return &req_wrap_queue_; } - void AddPromiseHook(promise_hook_func fn, void* arg); - bool RemovePromiseHook(promise_hook_func fn, void* arg); inline bool EmitProcessEnvWarning() { bool current_value = emit_env_nonstring_warning_; emit_env_nonstring_warning_ = false; @@ -1164,13 +1162,6 @@ class Environment { std::list<ExitCallback> at_exit_functions_; - struct PromiseHookCallback { - promise_hook_func cb_; - void* arg_; - size_t enable_count_; - }; - std::vector<PromiseHookCallback> promise_hooks_; - struct NativeImmediateCallback { native_immediate_callback cb_; void* data_; @@ -1214,10 +1205,6 @@ class Environment { // Used by embedders to shutdown running Node instance. AsyncRequest thread_stopper_; - static void EnvPromiseHook(v8::PromiseHookType type, - v8::Local<v8::Promise> promise, - v8::Local<v8::Value> parent); - template <typename T> void ForEachBaseObject(T&& iterator); |