src: yield empty maybes for failed AsyncWrap::MakeCallback calls

Use an empty `MaybeLocal<Value>` as the return value for
`AsyncWrap::MakeCallback()` if an exception occurred,
regardless of `MakeCallback` depth.

Unfortunately, the public API can not make this switch without
a breaking change (and possibly some kind of deprecation/renaming).

PR-URL: https://github.com/nodejs/node/pull/22078
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Ujjwal Sharma <usharma1998@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>

1 files changed, 2 insertions, 1 deletions

diff --git a/src/env.h b/src/env.h
index 87085bf946..7a4804cdd4 100644
--- a/src/env.h
+++ b/src/env.h
@@ -499,7 +499,6 @@ class Environment {
     AsyncCallbackScope() = delete;
     explicit AsyncCallbackScope(Environment* env);
     ~AsyncCallbackScope();
-    inline bool in_makecallback() const;
 
    private:
     Environment* env_;
@@ -507,6 +506,8 @@ class Environment {
     DISALLOW_COPY_AND_ASSIGN(AsyncCallbackScope);
   };
 
+  inline size_t makecallback_depth() const;
+
   class ImmediateInfo {
    public:
     inline AliasedBuffer<uint32_t, v8::Uint32Array>& fields();