summaryrefslogtreecommitdiff
path: root/src/env.h
diff options
context:
space:
mode:
authorAnna Henningsen <anna@addaleax.net>2018-10-20 11:02:37 +0200
committerMatheus Marchini <mat@mmarchini.me>2018-10-24 11:18:47 -0300
commit036fbdb63d603a64bd8562ec9331dfb7a5c5075c (patch)
tree074fd39f0951479bb0daac154c4a9e291b917804 /src/env.h
parentd568b53931958075be962ce79d23c24307af66f5 (diff)
downloadandroid-node-v8-036fbdb63d603a64bd8562ec9331dfb7a5c5075c.tar.gz
android-node-v8-036fbdb63d603a64bd8562ec9331dfb7a5c5075c.tar.bz2
android-node-v8-036fbdb63d603a64bd8562ec9331dfb7a5c5075c.zip
src: remove `Environment::tracing_agent_writer()`
As per the conversation in https://github.com/nodejs/node/issues/22513, this is essentially global, and adding this on the Environment is generally just confusing. Refs: https://github.com/nodejs/node/issues/22513 Fixes: https://github.com/nodejs/node/issues/22767 PR-URL: https://github.com/nodejs/node/pull/23781 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Matheus Marchini <mat@mmarchini.me>
Diffstat (limited to 'src/env.h')
-rw-r--r--src/env.h5
1 files changed, 1 insertions, 4 deletions
diff --git a/src/env.h b/src/env.h
index a85058f895..36e4169b4b 100644
--- a/src/env.h
+++ b/src/env.h
@@ -593,8 +593,7 @@ class Environment {
static inline Environment* GetThreadLocalEnv();
Environment(IsolateData* isolate_data,
- v8::Local<v8::Context> context,
- tracing::AgentWriterHandle* tracing_agent_writer);
+ v8::Local<v8::Context> context);
~Environment();
void Start(const std::vector<std::string>& args,
@@ -630,7 +629,6 @@ class Environment {
inline bool profiler_idle_notifier_started() const;
inline v8::Isolate* isolate() const;
- inline tracing::AgentWriterHandle* tracing_agent_writer() const;
inline uv_loop_t* event_loop() const;
inline uint32_t watched_providers() const;
@@ -921,7 +919,6 @@ class Environment {
v8::Isolate* const isolate_;
IsolateData* const isolate_data_;
- tracing::AgentWriterHandle* const tracing_agent_writer_;
uv_timer_t timer_handle_;
uv_check_t immediate_check_handle_;
uv_idle_t immediate_idle_handle_;